check_localizable exclude vendor dir#297
Merged
mbussolotto merged 1 commit intouyuni-project:mainfrom May 15, 2024
Merged
Conversation
mbussolotto
force-pushed
the
vendor_localizable
branch
from
d14459c to
044ac8f
Compare
cbosdo
reviewed
May 13, 2024
mbussolotto
force-pushed
the
vendor_localizable
branch
from
8ed3625 to
7259146
Compare
cbosdo
approved these changes
May 13, 2024
mbussolotto
force-pushed
the
vendor_localizable
branch
from
4de0d92 to
c5ca49e
Compare
mbussolotto
added a commit
to mbussolotto/uyuni-tools
that referenced
this pull request
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
go mod vendorcommand can be used to download golang dependencies invendorfolder (e.g.devcontainer). We want to exclude this folder fromcheck_localizableTest coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!