Do not enable dns plugin for proxy podman network #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbosdo
requested changes
May 13, 2024
This PR contains the changes I made here #298 |
|
you would need to rebase on PR #298 since Michele addressed the comments there. |
aaannz
force-pushed
the
no-dns-uyuni-net
branch
2 times, most recently
from
24aba74 to
9472ba9
Compare
|
Rebased. I don't know why localization test is failing. |
This is an issue with a PR Michele just merged. Could you please rebase on latest |
|
Done. Thanks |
cbosdo
approved these changes
May 15, 2024
mbussolotto
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
We do not need inter-container hostname desolution for proxy as we just use localhost in the pod. This also fixed currently broken aardvark behavior.
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24305
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!