-
Notifications
You must be signed in to change notification settings - Fork 25
coco attestation container improvements #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2eb4c9
to
89d4a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comment, most of them are just about missing comments or return value.
Besides that:
- is it right to not have server attestation for uyuni on kubernetes?
- is there any better way to scale podman (maybe using
pod
?
cc @cbosdo
7f71e9f
to
753c5b3
Compare
kubernetes support for server attestation will come later we wanted to get the podman version working first.
if there is i'm not aware of it.
|
753c5b3
to
c996c99
Compare
It's not right, but we can afford doing it later, still I don't like skipping kubernetes parts for too long as that means we could overlook important differences with the podman implementation.
Sadly no, there is no better way. podman doesn't have an equivalent of kubernetes |
c996c99
to
5a19343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll see quite some changes after a rebase on master. The PR looks good, but I added suggestions for changes after the new l10n rework that has been merged.
6296f27
to
5f67450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One forgotten utils.Errorf()
and some suggestion on the supported containers error / help.
2aec578
to
be157c2
Compare
be157c2
to
501841d
Compare
501841d
to
e5a39ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lucidd you can proceed with the merge please. |
What does this PR change?
This adds support for multiple instances of the confidential computing attestation container and a scale command to adjust the replicas.
Test coverage
No tests
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24238 https://github.com/SUSE/spacewalk/issues/24205
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!