Skip to content

coco attestation container improvements #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

lucidd
Copy link
Member

@lucidd lucidd commented May 13, 2024

What does this PR change?

This adds support for multiple instances of the confidential computing attestation container and a scale command to adjust the replicas.

Test coverage

  • No tests

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24238 https://github.com/SUSE/spacewalk/issues/24205

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@lucidd lucidd requested a review from mbussolotto May 13, 2024 13:18
@lucidd lucidd force-pushed the coco-attestation-container branch 3 times, most recently from d2eb4c9 to 89d4a12 Compare May 13, 2024 14:02
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comment, most of them are just about missing comments or return value.
Besides that:

  • is it right to not have server attestation for uyuni on kubernetes?
  • is there any better way to scale podman (maybe using pod?
    cc @cbosdo

@lucidd lucidd force-pushed the coco-attestation-container branch 2 times, most recently from 7f71e9f to 753c5b3 Compare May 13, 2024 15:58
@lucidd
Copy link
Member Author

lucidd commented May 13, 2024

I left some comment, most of them are just about missing comments or return value. Besides that:

  • is it right to not have server attestation for uyuni on kubernetes?

kubernetes support for server attestation will come later we wanted to get the podman version working first.

  • is there any better way to scale podman (maybe using pod?

if there is i'm not aware of it.

cc @cbosdo

@lucidd lucidd force-pushed the coco-attestation-container branch from 753c5b3 to c996c99 Compare May 13, 2024 16:18
@cbosdo
Copy link
Contributor

cbosdo commented May 14, 2024

* is it right to not have server attestation for uyuni on kubernetes?

It's not right, but we can afford doing it later, still I don't like skipping kubernetes parts for too long as that means we could overlook important differences with the podman implementation.

* is there any better way to scale podman (maybe using `pod`?

Sadly no, there is no better way. podman doesn't have an equivalent of kubernetes deployment or replicaSet.

@lucidd lucidd force-pushed the coco-attestation-container branch from c996c99 to 5a19343 Compare May 14, 2024 09:07
@lucidd lucidd requested review from cbosdo and mbussolotto May 14, 2024 13:58
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll see quite some changes after a rebase on master. The PR looks good, but I added suggestions for changes after the new l10n rework that has been merged.

@lucidd lucidd force-pushed the coco-attestation-container branch 2 times, most recently from 6296f27 to 5f67450 Compare May 16, 2024 09:30
@lucidd lucidd requested a review from cbosdo May 16, 2024 09:38
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One forgotten utils.Errorf() and some suggestion on the supported containers error / help.

@lucidd lucidd force-pushed the coco-attestation-container branch 2 times, most recently from 2aec578 to be157c2 Compare May 16, 2024 11:33
@lucidd lucidd requested a review from cbosdo May 16, 2024 13:42
@cbosdo cbosdo changed the title coco attestation container impovements coco attestation container improvements May 16, 2024
@lucidd lucidd force-pushed the coco-attestation-container branch from be157c2 to 501841d Compare May 16, 2024 15:39
@lucidd lucidd force-pushed the coco-attestation-container branch from 501841d to e5a39ac Compare May 16, 2024 15:54
Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@admd
Copy link
Contributor

admd commented May 17, 2024

@lucidd you can proceed with the merge please.

@admd admd merged commit 6e05b40 into main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants