Skip to content

During migration, improve info about usage on ssl-password and logs(bsc#1243009) #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented May 19, 2025

What does this PR change?

Codespace

Check if you already have a running container clicking on Running CodeSpace

Create CodeSpace About billing for Github Codespaces CodeSpace Billing Summary CodeSpace Limit

Test coverage

  • Unit tests were added

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/27192

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@mbussolotto mbussolotto requested a review from cbosdo May 19, 2025 12:37
@mbussolotto mbussolotto force-pushed the cert_escape_char branch 5 times, most recently from 42186e5 to c0a2dc6 Compare May 19, 2025 12:47
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen where we make the SSL error message a bit more obvious, but may be I'm blind

@mbussolotto mbussolotto force-pushed the cert_escape_char branch 3 times, most recently from ce6806a to eaf239d Compare May 19, 2025 13:19
@mbussolotto
Copy link
Member Author

mbussolotto commented May 19, 2025

I haven't seen where we make the SSL error message a bit more obvious, but may be I'm blind

You're not blind, it's not present. But since the with REDACT is fixed, now the output should be the one of rhn-ssl-tool (maybe wrong password or something like that)

@mbussolotto
Copy link
Member Author

I haven't seen where we make the SSL error message a bit more obvious, but may be I'm blind

You're not blind, it's not present. But since the with REDACT is fixed, now the output should be the one of rhn-ssl-tool (maybe wrong password or something like that)

I added it

@mbussolotto mbussolotto changed the title During migration, improve info about usage on ssl-password and logs (bsc#1243009) Migration and upgrade fixes (bsc#1243009) (bsc#1243329) May 20, 2025
@mbussolotto mbussolotto force-pushed the cert_escape_char branch 4 times, most recently from 99d3ee6 to 9194ece Compare May 20, 2025 12:46
@mbussolotto mbussolotto force-pushed the cert_escape_char branch 3 times, most recently from 641d555 to 47c7605 Compare May 21, 2025 09:13
@mbussolotto mbussolotto changed the title Migration and upgrade fixes (bsc#1243009) (bsc#1243329) During migration, improve info about usage on ssl-password and logs(bsc#1243009) May 21, 2025
@mbussolotto mbussolotto requested a review from cbosdo May 21, 2025 09:16
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should get the hostname rename change in the same PR as this one: it's a bit risky at this phase of the release

@deneb-alpha
Copy link
Contributor

deneb-alpha commented May 21, 2025

I'm not sure we should get the hostname rename change in the same PR as this one: it's a bit risky at this phase of the release

I agree. can we split the changes and have the hostname rename in a separate PR?
The rename bsc is even not mentioned in the PR description...

@cbosdo
Copy link
Contributor

cbosdo commented May 21, 2025

I'm not sure we should get the hostname rename change in the same PR as this one: it's a bit risky at this phase of the release

I agree. can we split the changes and have the hostname rename in a separate PR? The rename bsc is even not mentioned in the PR description...

The hostname rename has its own PR, it's just that this one is based on it to reuse some refactoring I made. Let me see if we can just extract the refactoring in a small commit and share it between the two PRs.

@mbussolotto
Copy link
Member Author

this was not intended. I cherrypicked that change so the rebase would be easier once we'll merge it.

@mbussolotto
Copy link
Member Author

Just to be more clear, this PR requires changes present in the other PR. Resolving conflict after might be a real mess, so the idea is simply to remove that commit once the other PR will be merged (maybe rebase it will be smart enough).

@mbussolotto mbussolotto requested a review from aaannz June 5, 2025 15:51
Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link

sonarqubecloud bot commented Jun 6, 2025

@mbussolotto mbussolotto merged commit c091832 into uyuni-project:main Jun 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants