-
Notifications
You must be signed in to change notification settings - Fork 25
During migration, improve info about usage on ssl-password and logs(bsc#1243009) #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42186e5
to
c0a2dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen where we make the SSL error message a bit more obvious, but may be I'm blind
ce6806a
to
eaf239d
Compare
You're not blind, it's not present. But since the with REDACT is fixed, now the output should be the one of |
eaf239d
to
bb06b41
Compare
I added it |
bb06b41
to
9507eec
Compare
99d3ee6
to
9194ece
Compare
641d555
to
47c7605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should get the hostname rename change in the same PR as this one: it's a bit risky at this phase of the release
I agree. can we split the changes and have the hostname rename in a separate PR? |
The hostname rename has its own PR, it's just that this one is based on it to reuse some refactoring I made. Let me see if we can just extract the refactoring in a small commit and share it between the two PRs. |
this was not intended. I cherrypicked that change so the rebase would be easier once we'll merge it. |
Just to be more clear, this PR requires changes present in the other PR. Resolving conflict after might be a real mess, so the idea is simply to remove that commit once the other PR will be merged (maybe rebase it will be smart enough). |
47c7605
to
ab4f3d6
Compare
|
ac37c74
to
44a5a92
Compare
44a5a92
to
f43318e
Compare
Co-authored-by: Ondřej Holeček <[email protected]>
f43318e
to
d2e16d5
Compare
|
What does this PR change?
Codespace
Check if you already have a running container clicking on
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/27192
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!