Ensure we don't break Debian12 builds #591
Conversation
.github/workflows/debian12_build.yml
Outdated
| @@ -0,0 +1,53 @@ | |||
| # SPDX-FileCopyrightText: 2023 SUSE LLC | |||
There was a problem hiding this comment.
| # SPDX-FileCopyrightText: 2023 SUSE LLC | |
| # SPDX-FileCopyrightText: 2025 SUSE LLC |
do you think it could make sense to rename the workflow and call it just debian_build.yml? I'm thinking at future needs to keep the test when debian 12 will be EOL, but still we could have similar problems with the new stable.
apart from this, thanks for the nice touch and care for debian :)
There was a problem hiding this comment.
I would not even mention debian: it's basically the lowest go we support building with. However I could not come with a satisfactory name.
There was a problem hiding this comment.
I would not even mention debian: it's basically the lowest go we support building with. However I could not come with a satisfactory name.
legacy_go_build.yml? yes, we are facing the hardest problem in IT... naming 😅
There was a problem hiding this comment.
just saw your force push. also that looks fine
For debian 12 we still build with go 1.19 and nok8s tag to avoid the backports. Make sure it still builds.
|
What does this PR change?
For debian 12 we still build with go 1.19 and nok8s tag to avoid the backports. Make sure it still builds.
Test coverage
No tests: build checks
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!