Do not print an error if /etc/susemanager-release does not exist #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deneb-alpha
force-pushed
the
susemanager-release_ServerInspectData
branch
from
4225675 to
27b1f8b
Compare
deneb-alpha
force-pushed
the
susemanager-release_ServerInspectData
branch
from
27b1f8b to
a8630aa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Currently, when running Uyuni, the attempt to parse the non existing
/etc/susemanager-releaseresults in a misleading message in the logs likesed: can't read /etc/susemanager-release: No such file or directory.Even if this missing config file is not a problem and actually is expected on Uyuni, the message is misleading and gives the impression that there's a real issue.
See for example: uyuni-project/uyuni#10401
The PR change the way to compute the
suse_manager_release, validating first if the file exists or if, like in the case of an Uyuni setup, the file is expected to be missing. With this validation, the sed command doesn't print the messagecan't read /etc/susemanager-release: No such file or directorybut, when the file exists, the value is correctly extracted and stored.Codespace
Check if you already have a running container clicking on
Test coverage
Adapted test
DONE
Links
Fixes: uyuni-project/uyuni#10279
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!