Skip to content

Check for CA validity before doing any real upgrade work #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

aaannz
Copy link
Contributor

@aaannz aaannz commented Jun 5, 2025

What does this PR change?

We need to be sure about CA can generate certificates before attempting any upgrade work. Fail sooner rather then too late.

Codespace

Check if you already have a running container clicking on Running CodeSpace

Create CodeSpace About billing for Github Codespaces CodeSpace Billing Summary CodeSpace Limit

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • DONE

Links

Issue(s): uyuni-project/uyuni#10413

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

Copy link

sonarqubecloud bot commented Jun 5, 2025

Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 2024.12:

  • mgradm upgrade podman with wrong password -> it fails quickly
  • then mgradm upgrade podman with right password -> successful

Before, after the second upgrade the system was in a bad shape.

@aaannz aaannz merged commit ab0e53a into uyuni-project:main Jun 5, 2025
9 of 10 checks passed
@aaannz aaannz deleted the upgrade_ssl_ca_fix branch June 5, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants