In Unit Tests use a Salt Minion Server as default system

[mcalmer]

What does this PR change?

In our unit tests we use test functions which create system entries. These system entries are in most cases
traditional systems (aka EnterpriseEntitled).
Uyuni does not support these systems anymore. Today nearly everything is a SaltEntitled MinionServer.

This PR change the default of the test functions to create MinionServer and it adapt the tests to workaround the problems
which show up with this change.

Some tests cannot be changed to MinionServer. In these cases we explicitly create EnterpriseEntitled systems.
Sometimes this is needed as the functionality is not available for MinionServer. Mid term we can try to identify these
functionalities and remove them with the tests.

GUI diff

No difference.

• DONE

Documentation

• No documentation needed: only internal and user invisible changes

• DONE

Test coverage

• Unit tests adapted

• DONE

Links

Issues(s): https://github.com/SUSE/spacewalk/issues/25085
Port(s): ???

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10435/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10435/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[CDellaGiusta]

LGTM

[cbosdo]

Why would we have to mock JSP to create a minion?

[mcalmer]

A Minion is often executing something via taskomatic API which needs to be mocked in a unit test.
Here the Edit Details page has a taskomatic object getting it from the GlobalInstanceHolder and I have no idea how to get a mocked object to it.
Feel free to debug that with a SaltMinion :-)