Skip to content

Changes before the presentation at HL2025 v2#4

Merged
Alex2ndr merged 1 commit intomasterfrom
fixes_for_demo2
Nov 4, 2025
Merged

Changes before the presentation at HL2025 v2#4
Alex2ndr merged 1 commit intomasterfrom
fixes_for_demo2

Conversation

@Alex2ndr
Copy link
Collaborator

@Alex2ndr Alex2ndr commented Nov 3, 2025

  • Fixed a typo in the README.md
  • Added instructions for setting up an edge router for the demo stand
  • Added a full network diagram of the demo stand
  • Added configuration for CEOS
  • Fixed some of the parameters in evpn config for the demo stand

@gemini-code-assist
Copy link

Summary of Changes

Hello @Alex2ndr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the setup documentation and configuration for the demo environment, specifically in preparation for the HL2025 v2 presentation. It introduces detailed steps for integrating an edge router using CEOS, refines the existing compute node setup guides, and adjusts EVPN-related parameters to ensure a robust and accurate demonstration network. The changes aim to streamline the deployment process and improve the overall clarity of the demo setup instructions.

Highlights

  • Demo Environment Setup: Comprehensive instructions have been added for setting up an edge router (CEOS) for the demo stand, including Docker installation, CEOS image import, container execution, network configuration, and applying specific CEOS configurations.
  • Documentation Refinement: The documentation for preparing compute nodes has been renamed and updated to include more specific details like interface names for IP addresses, and the path for copying daemon configurations has been corrected.
  • EVPN Configuration Updates: EVPN connector configurations for compute nodes have been updated to include router_mac_type5 parameters and a dedicated [daemon] section with a configs_dir.
  • README Maintenance: A minor typo in the README.md file regarding Python prerequisites was corrected, and the example evpn-connector command now points to a standard configuration file path.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several changes to prepare for a demo, including documentation updates, new configuration files for a border router (CEOS), and adjustments to existing demo configurations. My review focuses on the new documentation for setting up the demo environment. I've found several issues in the setup scripts, such as incorrect commands and potential for user confusion, which could prevent the demo from being set up correctly. I've provided suggestions to fix these issues. The configuration changes themselves look reasonable for a demo environment.

@Alex2ndr Alex2ndr force-pushed the fixes_for_demo2 branch 2 times, most recently from b8b85ea to 8d394c3 Compare November 3, 2025 20:13
@Alex2ndr Alex2ndr requested review from gmelikov and vm86 November 3, 2025 21:25
* Fixed a typo in the README.md
* Added instructions for setting up an edge router for the demo stand
* Added a full network diagram of the demo stand
* Added configuration for CEOS
* Fixed some of the parameters in evpn config for the demo stand
@Alex2ndr Alex2ndr merged commit 8a15581 into master Nov 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants