Changes before the presentation at HL2025 v2#4
Conversation
Alex2ndr
commented
Nov 3, 2025
- Fixed a typo in the README.md
- Added instructions for setting up an edge router for the demo stand
- Added a full network diagram of the demo stand
- Added configuration for CEOS
- Fixed some of the parameters in evpn config for the demo stand
Summary of ChangesHello @Alex2ndr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the setup documentation and configuration for the demo environment, specifically in preparation for the HL2025 v2 presentation. It introduces detailed steps for integrating an edge router using CEOS, refines the existing compute node setup guides, and adjusts EVPN-related parameters to ensure a robust and accurate demonstration network. The changes aim to streamline the deployment process and improve the overall clarity of the demo setup instructions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several changes to prepare for a demo, including documentation updates, new configuration files for a border router (CEOS), and adjustments to existing demo configurations. My review focuses on the new documentation for setting up the demo environment. I've found several issues in the setup scripts, such as incorrect commands and potential for user confusion, which could prevent the demo from being set up correctly. I've provided suggestions to fix these issues. The configuration changes themselves look reasonable for a demo environment.
b8b85ea to
8d394c3
Compare
* Fixed a typo in the README.md * Added instructions for setting up an edge router for the demo stand * Added a full network diagram of the demo stand * Added configuration for CEOS * Fixed some of the parameters in evpn config for the demo stand
8d394c3 to
aecd64d
Compare