Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

edison1105 · 2025-05-27T10:47:44Z

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where calling defineModel() without assigning it to a variable would cause an error. Now, defineModel() can be used as a standalone call without assignment.
Tests
- Updated test cases to reflect the new behavior of defineModel(), removing assignment requirements and related error checks.

…ut varia…" This reverts commit 00734af.

coderabbitai · 2025-05-27T10:47:51Z

Walkthrough

The changes remove the requirement for defineModel() to be assigned to a variable in <script setup> blocks. Validation logic enforcing this assignment is eliminated, related error messages are removed from tests, and existing tests are updated to directly invoke defineModel() as a standalone expression without assignment.

Changes

Files	Change Summary
packages/compiler-sfc/src/script/defineModel.ts	Removed validation that enforced assignment of `defineModel()` to a variable.
packages/compiler-sfc/tests/compileScript.spec.ts	Updated tests to call `defineModel()` directly, removing assignment to a variable.
packages/compiler-sfc/tests/compileScript/defineModel.spec.ts	Removed test that checked for error when `defineModel()` is not assigned to a variable.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Compiler
    participant defineModel

    User->>Compiler: Writes <script setup> with defineModel({...})
    Compiler->>defineModel: Processes defineModel({...}) call
    defineModel-->>Compiler: Returns model declaration (no assignment check)
    Compiler-->>User: Compiles script without requiring assignment

Poem

A bunny hopped through lines of code,
Where models once had strict abode.
No need for names, just call away—
The rules have changed as of today!
With freedom found in every hop,
The carrot’s near—no need to stop!
🥕✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5ada3d and 2a94d2f.

📒 Files selected for processing (3)

packages/compiler-sfc/__tests__/compileScript.spec.ts (3 hunks)
packages/compiler-sfc/__tests__/compileScript/defineModel.spec.ts (0 hunks)
packages/compiler-sfc/src/script/defineModel.ts (0 hunks)

💤 Files with no reviewable changes (2)

packages/compiler-sfc/tests/compileScript/defineModel.spec.ts
packages/compiler-sfc/src/script/defineModel.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed
GitHub Check: test / unit-test-windows

🔇 Additional comments (3)

packages/compiler-sfc/__tests__/compileScript.spec.ts (3)

1010-1012: LGTM! Test correctly updated to reflect the revert.

The test has been appropriately updated to call defineModel() directly without assignment, which aligns with the revert of the requirement for variable assignment. The test logic remains intact and continues to verify that referencing local let variables throws an error.

1020-1022: LGTM! Consistent test update for const variable reference.

The test correctly maintains its logic to verify that defineModel() can reference const variables without throwing an error, while removing the variable assignment requirement as intended by the revert.

1030-1032: LGTM! Test properly updated for get/set option validation.

The test maintains its purpose of verifying that local variables can be referenced in get and set options without throwing errors, while correctly implementing the removal of the variable assignment requirement.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-05-27T10:49:00Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13390

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13390

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13390

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13390

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13390

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13390

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13390

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13390

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13390

vue

npm i https://pkg.pr.new/vue@13390

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13390

commit: 2a94d2f

github-actions · 2025-05-27T10:49:02Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24 kB

Revert "fix(compiler-sfc): add error handling for defineModel() witho…

2a94d2f

…ut varia…" This reverts commit 00734af.

edison1105 merged commit 42f879f into main May 27, 2025
14 of 16 checks passed

edison1105 deleted the revert-13352-fix/define-model-error branch May 27, 2025 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

Uh oh!

edison1105 commented May 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

Revert "fix(compiler-sfc): add error handling for defineModel() without variable assignment" #13390

Uh oh!

Conversation

edison1105 commented May 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Size Report

Bundles

Usages

Uh oh!

Uh oh!

Uh oh!

edison1105 commented May 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)