Test result submission UX #1350 #1474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved "Submit Results" button to appear before "Next Test" - Added a confirmation modal that prompts user before submitting results - Ensured test state persists correctly on submission - No changes made to E2E test file; functionality verified in dev environment
…tion - Moved saveForm() to top-level and called it before modal dialog is shown - Simplified modal confirmation logic to only handle navigation - Removed 'goToNextTest' clause from performButtonAction - Cleaned up commented code and verified test state persists across navigation - All E2E tests in TestRun suite are passing
…tests Now that modal confirmation is handled directly during test navigation, the manual Yes button checks (yesButton1, yesButton2, yesButton3) are no longer needed. This commit simplifies the E2E test file and ensures all tests still pass after cleanup.
rohitsen49
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the test navigation experience in the TestRun flow by:
saveForm()logic to occur before the modal confirmation appearsnavigateTests(...)goToNextTestclause fromperformButtonActionAdditional Changes
TestRun.e2e.test.jsto reflect the new modal flowyesButton1,yesButton2, andyesButton3conditional logicNotes
These changes address issue #1350 and ensure that form state is preserved when navigating between tests. This update improves test reliability and helps users avoid accidentally losing unsaved results.