Skip to content

Conversation

howard-e
Copy link
Contributor

Address #1377

@ccanash ccanash requested review from stalgiag and ChrisC and removed request for stalgiag August 25, 2025 20:09
Copy link
Contributor

@ChrisC ChrisC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howard-e I haven't pulled this down to test yet but looking over the code, it seems like this will just return an existing test plan run if one already exists for the matching AT version. Is that correct?

If so, I think it might be a more useful experience for the user if we block the process and instead let the user know that the test plan run for that version already exists, and that they can't add again.

It would also be great if there were smaller localized tests here, either at the service level on the server side or on the component side. (Looks like there's already some component tests with mocks here...)

@howard-e
Copy link
Contributor Author

howard-e commented Sep 2, 2025

@howard-e I haven't pulled this down to test yet but looking over the code, it seems like this will just return an existing test plan run if one already exists for the matching AT version. Is that correct?

Correct

If so, I think it might be a more useful experience for the user if we block the process and instead let the user know that the test plan run for that version already exists, and that they can't add again.

Good thought! I can add this approach to the PR. Was initially thinking preventing on the gql layer is helpful to prevent any chance of it happening through a query (accidental or otherwise).

It would also be great if there were smaller localized tests here, either at the service level on the server side or on the component side. (Looks like there's already some component tests with mocks here...)

I can certainly expand those!

@ChrisC
Copy link
Contributor

ChrisC commented Sep 2, 2025

Good thought! I can add this approach to the PR. Was initially thinking preventing on the gql layer is helpful to prevent any chance of it happening through a query (accidental or otherwise).

I like that. It seems if we could prevent on the gql layer then maybe we could even prevent the AT version even showing up in the dropdown as an option to add to the test queue, if that version is already in the queue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants