Skip to content

All Pages: Update SkipTo feature to version 5.7.4 #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jan 14, 2025

Updates include:

  • Scollto landmark or heading feature when navigating menu items
  • Added number of headings and landmarks to group labels
  • Scrolling list for landmarks and headings when there are a large number of either one, so the group labels are always vsible
  • Added an about option in the menu for people to learn abut SkipTo.js
  • Support light-dark color scheme
  • Support forced-colors media query

WAI Preview Link (Last built on Sat, 15 Feb 2025 02:16:26 GMT).

@jongund jongund changed the title updated SkipTo.js to version 5.7.2 updated SkipTo.js to version 5.7.4 Feb 15, 2025
@mcking65 mcking65 changed the title updated SkipTo.js to version 5.7.4 All Pages: Update SkipTo feature to version 5.7.4 May 19, 2025
@mcking65
Copy link
Contributor

@jongund

I'm finding the extra information in the group labels very distracting. It is making the menu content harder to understand.

Why is it including only headings in main? Seems like we should not be limiting the list of headings to main content. I don't recall when that change was made, but I'm not sure it's the most desirable approach.

The more information button in the about dialog gives a 404.

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Pull request 3213 - Update skipTo.

The full IRC log of that discussion <jugglinmike> Topic: Pull request 3213 - Update skipTo
<jugglinmike> github: https://github.com//pull/3213
<jugglinmike> Matt_King: I added some comments to the pull request
<jugglinmike> Matt_King: Before we dive in: in general, jongund made changes to the menu that is included at the top of each page
<jugglinmike> Matt_King: This skipTo includes both landmark regions and headings, but only headings in the main content. I didn't realize that until yesterday. I'm wondering where that decision came from--that we would exclude headings from any other part of the page
<jugglinmike> jongund: That is configurable in skipTo. We can reconfigure it to show all headings
<jugglinmike> jongund: There's now browser extension versions of skipTo where users have access to a lot of configuration
<jugglinmike> Matt_King: That configuration appears on every single page--we don't have it centrally.
<jugglinmike> jongund: I could change the default to be all headings
<jugglinmike> Zakim, end the meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants