Skip to content

Example Disclosure for FAQ: Replace description list with unordered list #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 20, 2025

Fix #3269 with the following changes:

  • Replaces DL, DT and DD elements with OL and LI elements
  • Update CSS for new element selectors
  • Revise regression test to expect new element selectors
  • Fixed broken regression test

Preview Example Disclosure (Show/Hide) for Answers to Frequently Asked Questions | APG | WAI | W3C


WAI Preview Link (Last built on Wed, 04 Jun 2025 19:52:21 GMT).

@jongund jongund changed the title FAQ replaces DL with OL elements disclosure FAQ example replaces DL with OL elements May 20, 2025
@jongund jongund changed the title disclosure FAQ example replaces DL with OL elements Disclosure FAQ example replaces DL with OL elements May 20, 2025
@jongund jongund requested a review from mcking65 May 21, 2025 13:43
@jongund
Copy link
Contributor Author

jongund commented May 21, 2025

@howard-e

Hi Howard,
Do you know why I came getting the link check errors?
I branched this PR from main and didn't touch the file with the link error.

Thanks for your help

@howard-e
Copy link
Contributor

Hi Howard, Do you know why I came getting the link check errors? I branched this PR from main and didn't touch the file with the link error.

Hey @jongund, the link-checker solution was faulty with how it handled rate-limiting. I've just merged #3273 into main which makes it more robust so you can pull that in here (or I can if you're comfortable with me merging into your branches when there is a clear infra breakage).

The error Found broken external link on content/patterns/landmarks/examples/resources.html:58:33, hash "#landmarks" not found on page may be unique here as I can't reproduce locally and my re-running one of the link-checker builds got rid of it. But I can help to investigate further if it does pop up again after merging in main.

@jongund
Copy link
Contributor Author

jongund commented May 23, 2025

Thanks Howard,
I am traveling right now will try it early next week.

@mcking65 mcking65 changed the title Disclosure FAQ example replaces DL with OL elements Example Disclosure for FAQ: Replace description list with unordered list Jun 3, 2025
@mcking65 mcking65 requested review from adampage and howard-e June 3, 2025 18:33
jongund added 2 commits June 4, 2025 13:57
Merge branch 'main' into update-faq
@jongund
Copy link
Contributor Author

jongund commented Jun 4, 2025

@mcking65
Based on the minutes of the 3 June APG meeting, I updated the example to use UL instead of OL list markup.

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jongund, the *.js changes look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disclosure of Answers to Frequently Asked Questions: replace description list semantics
3 participants