#276: Unify ex namespace usage in tests - redo
#390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoucTagh
approved these changes
May 26, 2025
nicholascar
changed the title
ex namespace usage in testsex namespace usage in tests - redo
nicholascar
changed the title
ex namespace usage in tests - redoex namespace usage in tests - redo
nicholascar
changed the title
ex namespace usage in tests - redoex namespace usage in tests - redo
| @@ -28,11 +28,11 @@ ex:TestShape | |||
| ex:TestShape-sparql | |||
| sh:message "Cannot have a label" ; | |||
| sh:prefixes <http://datashapes.org/sh/tests/sparql/node/sparql-001.test> ; | |||
| sh:select """ | |||
There was a problem hiding this comment.
This hunk of lines is afflicted the the EOL character change.
| @@ -24,12 +24,12 @@ ex:LanguageExampleShape | |||
| rdf:type sh:SPARQLConstraint ; | |||
| sh:message "Values are literals with German language tag." ; | |||
| sh:prefixes <http://datashapes.org/sh/tests/sparql/node/sparql-003.test> ; | |||
| sh:select """ | |||
There was a problem hiding this comment.
This hunk of lines is afflicted the the EOL character change.
| @@ -23,10 +23,10 @@ ex:TestShape | |||
| ex:TestShape-sparql | |||
| sh:message "Test message" ; | |||
| sh:prefixes ex: ; | |||
| sh:select """ | |||
There was a problem hiding this comment.
This hunk of lines is afflicted the the EOL character change.
| @@ -22,16 +22,16 @@ ex:TestShape | |||
| . | |||
| ex:TestShape-sparql | |||
| sh:prefixes ex: ; | |||
| sh:select """ | |||
There was a problem hiding this comment.
This hunk of lines is afflicted the the EOL character change.
| @@ -28,11 +28,11 @@ ex:TestShape | |||
| ex:TestShape-sparql | |||
| sh:message "Cannot have a label" ; | |||
| sh:prefixes <http://datashapes.org/sh/tests/sparql/node/sparql-001.test> ; | |||
| sh:select """ | |||
There was a problem hiding this comment.
This hunk of lines is also affected by end of line changes.
I just noticed that the previous files with EOL changes were from the SHACL 1.0 test suite. Is this PR's scope 1.2's tests, or going back in time to 1.0 too?
|
I don't think we should touch old test cases or documents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use http://example.com/ns# for ex: everywhere but without changing line endings.
This PR is a direct replacement for PR #362 and, if merged, #362 can be closed.
Closes #276
Closes #362