Skip to content

Version announcement #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025
Merged

Version announcement #207

merged 4 commits into from
Jun 6, 2025

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jun 3, 2025

Server and parser behavior on unexpected version announcement.

Also: Mark "atomic" term as exported to silence warnings.

Fixes #161. Fixes #205.

See also w3c/rdf-star-wg#161 and Minutes from 2025-02-29.


Preview | Diff

@gkellogg gkellogg requested review from niklasl, afs, pchampin and hartig June 3, 2025 23:34
@gkellogg gkellogg added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Jun 3, 2025
spec/index.html Outdated
Comment on lines 557 to 563
<p class="note">As HTTP <a data-cite="webarch#frag-coneg">content negotiation</a> is advisory,
clients recieving a document should be prepared to properly handle a document
of the requested media type but potentially having a `version` other than what was
requested.
Systems may consider down-grading the content to an appropriate version
as discussed in <a href="#defined-version-labels" class="sectionRef"></a>,
or by returning a `406 "Not Acceptable"` status in the response.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "Systems" in the second sentence refer to clients (as mentioned in the first sentence) or to servers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to use "Clients" to be consistent. I'll do an update for this later today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But clients wouldn't return a 406, as the sentence would suggest after this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from a suggestion in the document, that if a client had requested 1.1, but received 1.2 they could do the downgrade on their side. Not unlike how in JSON-LD clients may receive a document and re-frame it or apply a context to get it into a better format. However, the 406 would not be something a client would do.

Suggestions from @hartig.

Co-authored-by: Olaf Hartig <[email protected]>
@gkellogg gkellogg requested a review from hartig June 5, 2025 22:15
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Olaf Hartig <[email protected]>
@gkellogg gkellogg merged commit d5dd6c2 into main Jun 6, 2025
2 checks passed
@gkellogg gkellogg deleted the version-announcement branch June 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion - what advice to put in RDF specs about the handling of version labels.
4 participants