secrets-outside-env: flag secrets in reusable workflow calls#1792
Open
secrets-outside-env: flag secrets in reusable workflow calls#1792
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
2 tasks
marcoieni
approved these changes
Mar 24, 2026
marcoieni
left a comment
There was a problem hiding this comment.
This works for me, thanks!
For unexperienced users, it might be useful to explain that in this case, converting to a github action or inlining the github action are the best ways to solve this.
Otherwise people might try to add environment: to the workflow only to find out later that it's not allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now emit auditor level findings for this audit on the callsites for reusable workflows, i.e. jobs that call a reusable workflow and reference
secretsin their own context, since reusable workflow jobs can't currently explicitly activate an environment (and reusable workflows that indirectly activate an environment can't read that environment's secrets).@marcoieni PTAL if you have time 🙂
See #1773.