Skip to content

secrets-outside-env: flag secrets in reusable workflow calls#1792

Open
woodruffw wants to merge 2 commits intomainfrom
ww/fix-1773
Open

secrets-outside-env: flag secrets in reusable workflow calls#1792
woodruffw wants to merge 2 commits intomainfrom
ww/fix-1773

Conversation

@woodruffw
Copy link
Member

We now emit auditor level findings for this audit on the callsites for reusable workflows, i.e. jobs that call a reusable workflow and reference secrets in their own context, since reusable workflow jobs can't currently explicitly activate an environment (and reusable workflows that indirectly activate an environment can't read that environment's secrets).

@marcoieni PTAL if you have time 🙂

See #1773.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this Mar 24, 2026
@woodruffw woodruffw added the enhancement New feature or request label Mar 24, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
Copy link

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, thanks!
For unexperienced users, it might be useful to explain that in this case, converting to a github action or inlining the github action are the best ways to solve this.
Otherwise people might try to add environment: to the workflow only to find out later that it's not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants