-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove DS from aggregator #138
Merged
Merged
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ae4014d
feat: remove DS from aggregator
ToniRamirezM 00c00eb
feat: remove DS from aggregator
ToniRamirezM 4bd18c4
feat: unit tests
ToniRamirezM 74c71fb
feat: unit tests
ToniRamirezM a8b6240
feat: unit tests
ToniRamirezM 6742b5b
fix: rust
ToniRamirezM df22143
fix: seq-sender tests
ToniRamirezM e13cf99
fix: local_config script
ToniRamirezM c27575a
fix: remove unused file
ToniRamirezM 016d99d
fix: default config
ToniRamirezM ed6daaf
fix: default config
ToniRamirezM a8f617c
fix: test config
ToniRamirezM 0bc6f27
fix: nil l1inforoot
ToniRamirezM f7d214b
feat: improve coverage
ToniRamirezM e62c8eb
feat: improve coverage
ToniRamirezM ad5f822
feat: improve coverage
ToniRamirezM c87bd02
feat: improve coverage
ToniRamirezM d823403
feat: improve coverage
ToniRamirezM f2bfb99
feat: improve coverage
ToniRamirezM f90fbff
feat: improve coverage
ToniRamirezM 65a7bdd
feat: improve coverage
ToniRamirezM a1558cc
feat: improve coverage
ToniRamirezM dca013e
feat: improve coverage
ToniRamirezM a516b33
feat: improve coverage
ToniRamirezM b4d77ca
fix: comments
ToniRamirezM 249a47c
feat: remove DS lib
ToniRamirezM 1cd576a
feat: resolve conflicts
ToniRamirezM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
-- +migrate Down | ||
CREATE TABLE aggregator.batch ( | ||
batch_num BIGINT NOT NULL, | ||
batch jsonb NOT NULL, | ||
datastream varchar NOT NULL, | ||
PRIMARY KEY (batch_num) | ||
); | ||
Stefan-Ethernal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
ALTER TABLE aggregator.proof | ||
ADD CONSTRAINT proof_batch_num_fkey FOREIGN KEY (batch_num) REFERENCES aggregator.batch (batch_num) ON DELETE CASCADE; | ||
|
||
Stefan-Ethernal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ALTER TABLE aggregator.sequence | ||
ADD CONSTRAINT sequence_from_batch_num_fkey FOREIGN KEY (from_batch_num) REFERENCES aggregator.batch (batch_num) ON DELETE CASCADE; | ||
|
||
Stefan-Ethernal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
-- +migrate Up | ||
ALTER TABLE aggregator.proof | ||
DROP CONSTRAINT IF EXISTS proof_batch_num_fkey; | ||
|
||
ALTER TABLE aggregator.sequence | ||
DROP CONSTRAINT IF EXISTS sequence_from_batch_num_fkey; | ||
|
||
DROP TABLE IF EXISTS aggregator.batch; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it checked that this conf param works with the new templated config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally on Kurtosis and it looks ok to me.