feat: remove DS from aggregator #138
Conversation
| @@ -112,21 +112,18 @@ type Config struct { | |||
| // final gas: 1100 | |||
| GasOffset uint64 `mapstructure:"GasOffset"` | |||
|
|
|||
| // RPCURL is the URL of the RPC server | |||
| RPCURL string `mapstructure:"RPCURL"` | |||
There was a problem hiding this comment.
Is it checked that this conf param works with the new templated config?
There was a problem hiding this comment.
I tested locally on Kurtosis and it looks ok to me.
| UseFullWitness = false | ||
| SettlementBackend = "l1" | ||
| AggLayerTxTimeout = "5m" | ||
| AggLayerURL = "{{AggLayerURL}}" | ||
| MaxWitnessRetrievalWorkers = 2 | ||
| SyncModeOnlyEnabled = false |
There was a problem hiding this comment.
aren't we using this anymore?
There was a problem hiding this comment.
Nop, now the witness is requested on the same thread a prover opens when connecting to the aggregator. CDK-Erigon is protected in case we request to much witnesses with the "busy" logic.
Very good point 😅 Just removed it now along an unused file in the state package that was importing it. |
|
* feat: remove DS from aggregator * feat: unit tests * fix: rust * fix: seq-sender tests * fix: local_config script * fix: remove unused file * fix: default config * fix: test config * fix: nil l1inforoot * feat: improve coverage * fix: comments * feat: remove DS lib
Description
Removes DS from Aggregator.