-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination for existing relationships #50
base: master
Are you sure you want to change the base?
Add pagination for existing relationships #50
Conversation
@crawfjs welcome to WP Content Connect and thanks for the PR, it's greatly appreciated! I'm checking with a teammate to see if they can give this a review and either provide feedback or merge this in, will keep you posted as that happens and if there are any questions or updates needed. Thanks again! |
@jeffpaul are there any plans to release this enhancement any time soon? We have a client that needs the number of relationships "limit" bumped. |
@s3rgiosan up to now @rickalee has been the core maintainer here, but if you feel comfortable leading things on a release then I'd be happy to help you get things tagged/released? |
@s3rgiosan any interest in resolving the conflicts here for @rickalee to review/approve for release on this as well? |
Sure. I can take a look tomorrow. |
@s3rgiosan any interest in resolving the conflicts here for @rickalee to review/approve for release on this as well? |
Description of the Change
This change implements pagination for the existing relationships (PickerList) and resolves an issue where relationships are removed when updating a post and there are more than ten relationships defined. This limited the number of relationships that the plugin would allow to ten.
Alternate Designs
Another consideration was to handle pagination server side. This would have been a heavier implementation, including a move from a save-all approach, to individual change sets / transactions.
Benefits
This is a light weight approach for the pagination, encapsulating within the component itself.
Possible Drawbacks
Since pagination is handled on the client side, it implements a select all approach. Could put a really high limit here (2000), but we could run into the data loss issue again.
Verification Process
For the changes to the project / setup, run any of these
npm run build-js
or
npm run dev-build-js
or
npm run watch-js
Functionality was tested in the following scenarios:
Checklist:
Applicable Issues
n/a
Changelog Entry