-
Notifications
You must be signed in to change notification settings - Fork 44
[PT1-52] added Makefile; updated deployment scripts #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive configuration management system and Makefile for automated deployment of escrow factory contracts and tokens. The changes centralize configuration in JSON files and provide environment-based deployment workflows.
Key changes:
- Added a configuration library to read deployment parameters from JSON
- Updated deployment scripts to use centralized configuration instead of hardcoded values
- Created a comprehensive Makefile with automated deployment, verification, and management targets
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| script/utils/Config.sol | New configuration library for reading deployment parameters from JSON files |
| script/DeployEscrowFactoryZkSync.s.sol | Updated to use Config library instead of hardcoded addresses |
| script/DeployEscrowFactory.s.sol | Updated to use Config library instead of hardcoded addresses |
| script/DeployERC20True.s.sol | New deployment script for ERC20True token with configuration support |
| foundry.toml | Added file system permission for reading config directory |
| config/constants.json | New JSON configuration file with deployment constants |
| Makefile | Comprehensive Makefile with deployment, verification, and management targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.