Skip to content

Release access-esm1p5 2024.12.1 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Release access-esm1p5 2024.12.1 #31

merged 4 commits into from
Apr 8, 2025

Conversation

dougiesquire
Copy link
Contributor

@dougiesquire dougiesquire commented Mar 26, 2025

This release:

Closes #30
Closes #34


🚀 The latest prerelease access-esm1p5/pr31-4 at 2bae283 is here: #31 (comment) 🚀

Includes:
- WOMBAT fix to prevent negative Schmidt numbers in warm temperatures (ACCESS-NRI/MOM5#36)
- Updates for oneapi compiler (ACCESS-NRI/MOM5#32)
Copy link

🚀 Attempted to deploy access-esm1p5 Prerelease pr31-1 with commit c01f667

🖥️ Gadi Deployment ❌

@dougiesquire
Copy link
Contributor Author

@aidanheerdegen, @blimlim are you okay with me also updatingspack-packages here? There have been a number of updates to ACCESS-ESM1.5 component packages, mostly relaxing version restrictions by the looks of things.

Copy link

🚀 Attempted to deploy access-esm1p5 Prerelease pr31-2 with commit 6285a3e

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-esm1.5 model will be deployed to Gadi as:

  • 2024.12.1 as a Release (when merged).
  • pr31-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p5/pr31-2

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p5-pr31-2 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.005
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@aidanheerdegen
Copy link
Member

@aidanheerdegen, @blimlim are you okay with me also updatingspack-packages here? There have been a number of updates to ACCESS-ESM1.5 component packages, mostly relaxing version restrictions by the looks of things.

Yep, but as it's more than just the WOMBAT code change we would normally run a repro test. However @blimlim and I had a chat and agreed that regardless if this changes the specific answers or not in the repro test the major version should be bumped because the WOMBAT code change will modify results for any simulation which had ocean temps exceeding 35 degrees.

Would you agree @dougiesquire?

@dougiesquire
Copy link
Contributor Author

Would you agree @dougiesquire?

I would

@blimlim blimlim temporarily deployed to Gadi Prerelease April 8, 2025 01:00 — with GitHub Actions Inactive
@blimlim
Copy link
Contributor

blimlim commented Apr 8, 2025

I've just added in the CICE error code changes. Should we change the version number to 2025.04.000?

Copy link

github-actions bot commented Apr 8, 2025

🚀 Attempted to deploy access-esm1p5 Prerelease pr31-3 with commit c3900a9

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-esm1.5 model will be deployed to Gadi as:

  • 2024.12.1 as a Release (when merged).
  • pr31-3 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p5/pr31-3

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p5-pr31-3 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.005
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@dougiesquire
Copy link
Contributor Author

Should we change the version number to 2025.04.000?

We had a similar discussion here. In that issue we decided to increment the minor version because (to use @aidanheerdegen's words) "the model is ostensibly unchanged but there are minor updates". I think that's also the case here?

I guess one benefit of 2025.04.000 is to move to the "new" versioning scheme

@dougiesquire
Copy link
Contributor Author

@blimlim, could you please add the CICE change to the PR description

@blimlim
Copy link
Contributor

blimlim commented Apr 8, 2025

@blimlim, could you please add the CICE change to the #31 (comment)

Can do, added in!

"the model is ostensibly unchanged but there are minor updates". I think that's also the case here?

Good question, I'm not 100% sure what's best here. I think from the earlier discussion here, we were thinking about bumping the major version though am happy either way if we expect the changes to not effect the model in a major way.

@dougiesquire
Copy link
Contributor Author

dougiesquire commented Apr 8, 2025

I think from the earlier discussion here, we were thinking about bumping the major version though am happy either way if we expect the changes to not effect the model in a major way.

Oh, I thought that discussion was about the config version. @aidanheerdegen can you set us straight

@blimlim
Copy link
Contributor

blimlim commented Apr 8, 2025

Oh, I thought that discussion was about the config version

Good point, you might be right. Admittedly I'm not too clear on the guidelines for config versions vs model versions.

Copy link
Contributor Author

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [email protected] makes sense here. This really is a very minor update. For the majority of users, the only change will be the CICE error output.

@blimlim would you be able to review?

@dougiesquire dougiesquire requested a review from blimlim April 8, 2025 04:33
@dougiesquire
Copy link
Contributor Author

We could go 2024.12.001 but it feels odd to me to change the syntax without changing the date

Copy link

github-actions bot commented Apr 8, 2025

🚀 Attempted to deploy access-esm1p5 Prerelease pr31-4 with commit 2bae283

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-esm1.5 model will be deployed to Gadi as:

  • 2024.12.1 as a Release (when merged).
  • pr31-4 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p5/pr31-4

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p5-pr31-4 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.006
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

Copy link
Contributor

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dougiesquire, looks good to me!

@aidanheerdegen
Copy link
Member

Why is every time a special case!? :)

Ugh.

Use 2024.12.1.

And yes the previous discussion about reproducibility was about the config version.

@dougiesquire dougiesquire merged commit 877a2da into main Apr 8, 2025
10 checks passed
@dougiesquire dougiesquire deleted the release-2024.12.1 branch April 8, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version with CICE error handling updates Release new version with WOMBAT fix
3 participants