-
Notifications
You must be signed in to change notification settings - Fork 0
Release access-esm1p5 2024.12.1 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes: - WOMBAT fix to prevent negative Schmidt numbers in warm temperatures (ACCESS-NRI/MOM5#36) - Updates for oneapi compiler (ACCESS-NRI/MOM5#32)
🚀 Attempted to deploy 🖥️
|
@aidanheerdegen, @blimlim are you okay with me also updating |
🚀 Attempted to deploy 🖥️
|
Yep, but as it's more than just the WOMBAT code change we would normally run a repro test. However @blimlim and I had a chat and agreed that regardless if this changes the specific answers or not in the repro test the major version should be bumped because the WOMBAT code change will modify results for any simulation which had ocean temps exceeding 35 degrees. Would you agree @dougiesquire? |
I would |
I've just added in the CICE error code changes. Should we change the version number to |
🚀 Attempted to deploy 🖥️
|
We had a similar discussion here. In that issue we decided to increment the minor version because (to use @aidanheerdegen's words) "the model is ostensibly unchanged but there are minor updates". I think that's also the case here? I guess one benefit of |
@blimlim, could you please add the CICE change to the PR description |
Can do, added in!
Good question, I'm not 100% sure what's best here. I think from the earlier discussion here, we were thinking about bumping the major version though am happy either way if we expect the changes to not effect the model in a major way. |
Oh, I thought that discussion was about the config version. @aidanheerdegen can you set us straight |
Good point, you might be right. Admittedly I'm not too clear on the guidelines for config versions vs model versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think [email protected]
makes sense here. This really is a very minor update. For the majority of users, the only change will be the CICE error output.
@blimlim would you be able to review?
We could go |
🚀 Attempted to deploy 🖥️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dougiesquire, looks good to me!
Why is every time a special case!? :) Ugh. Use And yes the previous discussion about reproducibility was about the config version. |
This release:
spack-packages
to 2025.03.006Closes #30
Closes #34
🚀 The latest prerelease
access-esm1p5/pr31-4
at 2bae283 is here: #31 (comment) 🚀