Skip to content

Fix fanboynz's automatic script issue #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Conversation

piquark6046
Copy link
Member

@piquark6046 piquark6046 commented Jun 21, 2025

Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@piquark6046 piquark6046 requested a review from a team June 21, 2025 06:09
@piquark6046 piquark6046 merged commit 7fba619 into master Jun 21, 2025
4 checks passed
@Yuki2718
Copy link
Contributor

Doesn't make sense, if such error happens again, it's NOT discord.

@piquark6046
Copy link
Member Author

Then, we can add another case that blocks any normal service's domain into the section in the future

@piquark6046 piquark6046 mentioned this pull request Jun 21, 2025
@Yuki2718
Copy link
Contributor

Yuki2718 commented Jun 21, 2025

I mean discord.com was already excluded in his script, what is the point of adding exclusion every time AFTER it became an issue and fixed in the script?

@BlazDT
Copy link
Contributor

BlazDT commented Jun 21, 2025

Discord.com got blocked several times in EasyList. I guess therefore to ensure it is not blocked anymore in the future.

@piquark6046
Copy link
Member Author

piquark6046 commented Jun 21, 2025

I mean discord.com was already excluded in his script, what is the point of adding exclusion every time AFTER it became an issue and fixed in the script?

I believe that the 2nd accident should not be happended because ||discord.com^ can be removed at the postprocessing (like checking any well-known web service's domain) of fanboynz's automatic script.

@Yuki2718
Copy link
Contributor

Discord.com got blocked several times in EasyList. I guess therefore to ensure it is not blocked anymore in the future.

Seems you're right about this: easylist/easylist@0924d8a So maybe excluding discord still makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants