feat: add agoric-upgrade-19 (proposal 91)

[muhammadahmadasifbhatti]

Description

This PR adopts governance proposal 91 as per upgrade 19. Created via following instructions here.
Companion agoric-sdk PR

When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks.

• before this PR, change any fromTag using latest (such as a3p-integration) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up)
• before merging this PR, include a link to a PR that adopts its fromTag use-${proposalName} (where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. a3p-integration/proposals)
• after this PR merges, merge that other PR

[Muneeb147]

@muhammadahmadasifbhatti We need to keep feat: add agoric-upgrade-19 (proposal 91) as single feat commit instead of init (might need to create a separate PR with the right commit incase we can't update the existing commit's message).
Also can we look at failure step? What is it about? We might need help from Mathieu or Mujahid for that.

[mujahidkay]

@muhammadahmadasifbhatti We need to keep feat: add agoric-upgrade-19 (proposal 91) as single feat commit instead of init (might need to create a separate PR with the right commit incase we can't update the existing commit's message).

Can just reword commit.

Also can we look at failure step? What is it about? We might need help from Mathieu or Mujahid for that.

@muhammadahmadasifbhatti we also need to copy the patches folder from a3p-integration

[Muneeb147]

@muhammadahmadasifbhatti
As mujahid said, we need to copy patches folder as well. The error is on patch

Reference for u18:
https://github.com/Agoric/agoric-3-proposals/pull/211/files#diff-2517680c6e2d34fc7f8a9ef0a41507b6dac12ce20aef495df5d8ae1ff86d6057
https://github.com/Agoric/agoric-3-proposals/pull/211/files#diff-a09aaa48f09db7c3bce6dca3d17939bf8896671b7f2e4301cbb7f4a238b73602

I guess the manual copying skipped .yarn folder.

[mujahidkay]

This README needs to be updated. It usually contains info regarding when the proposal was adopted on the chain i.e. the block height and its respective block time (see previous proposals for ref)

[muhammadahmadasifbhatti]

Updated.

[muhammadahmadasifbhatti]

@mhofman @turadg I have created this PR to adopt the governance proposal 91 as per the upgrade 19. Some tests are failing and I am unable to find the exact underlying reason.

I also checked why these tests were passing in the agoric-sdk on dev-upgrade-19 PR. It seemed like the last proposal layer was fast-usdc-beta instead of fast-usdc-rc1. So, I created this PR to see if the tests are passing by removing the fast-usdc-rc1 proposal. They are still failing due to the same reason.

Input will be appreciated.

[Muneeb147]

@muhammadahmadasifbhatti Can you please share more details? Which test exactly? What is the exact error? Is it consistently failing at one single point?

[muhammadahmadasifbhatti]

@Muneeb147

Can you please share more details? Which test exactly?

I have attached the links to the failed tests

What is the exact error?

Exact error on the console is:

console.error(`Run of ${name} failed with exit code ${runResult.status}`);
                                         ^
ReferenceError: name is not defined

But this is not the cause. Seems like some directories are missing that should have been created when we ran script/buill-all-submissions.sh.

Is it consistently failing at one single point?

Yes, it is consitently failing at the same point.

[Muneeb147]

@muhammadahmadasifbhatti
So pasting the exact test/error in the comment helps as the viewer can directly see the root-cause rather than having a friction of jumping to the links and finding the error.

[Muneeb147]

@muhammadahmadasifbhatti

Error: axios@patch:axios@npm%3A1.7.7#~/.yarn/patches/axios-npm-1.7.7-cfbedc233d.patch: ENOENT: no such file or directory, open '/usr/src/proposals/91:upgrade-19/.yarn/patches/axios-npm-1.7.7-cfbedc233d.patch'

Why are we seeing this error again? I see you have added patches folder in recent commit. Landed on this error from your Some tests link.

[muhammadahmadasifbhatti]

@Muneeb147 Wrong Link was attached. Updated it.

New update: The issue is with the scripts/build-all-submissions.sh. Ideally it should create the directories given in the sdk-generate in the package.json but, that's not the case.

I re-ran the scripts/build-all-submissions.sh and got this error.

#  node[89177]: void node::fs::InternalModuleStat(const FunctionCallbackInfo<Value> &) at ../src/node_file.cc:1056
  #  Assertion failed: (args.Length()) >= (2)

----- Native stack trace -----

 1: 0x102350840 node::Assert(node::AssertionInfo const&) [/opt/homebrew/Cellar/node/23.11.0/bin/node]
 2: 0x10236507c node::fs::InternalModuleStat(v8::FunctionCallbackInfo<v8::Value> const&) [/opt/homebrew/Cellar/node/23.11.0/bin/node]
 ...

Looking further into it.

[Muneeb147]

@muhammadahmadasifbhatti I see all green. That's great Ahmad ❤️❤️
So how did you figure out the problem and the solution eventually? Do we need to update docs as well for future reference?

[mujahidkay]

Please mark the relevant checkboxes as complete, and the remaining once you open the companion PR.

[muhammadahmadasifbhatti]

@muhammadahmadasifbhatti I see all green. That's great Ahmad ❤️❤️ So how did you figure out the problem and the solution eventually? Do we need to update docs as well for future reference?

I was not able to generate the directories mentioned in the sdk-generate in package.json due to a node error. Actually, I changed my machine recently, and it was using the latest node version. I checked the agorik-sdk docs and they state

We generally support latest version

So, I changed the version to the minimum version supported by agorik-sdk and got the sdk-generate directories.

[Chris-Hibbert]

I'm currently working on adding the fastUSDC coreEvals (proposals 87 and 88) to agoric-3-proposals. Please don't remove the current contents of n:upgrade-next and g:gtm-fast-usdc from a3p-integration until we have all these migrated.