feat(zoe): zoe part of minimal want patterns using M.containerHas(el,n)

[erights]

Staged on #11235 , which provides the E part

closes: #XXXX
refs: endojs/endo#2710 #1905 #1913 #1915 #2155 #2156 #2230 #4212 #4217 #10951 #11235

Description

Implements minimal want patterns, where the only supported pattern is M.containerHas

• Zoe-level changes to accept want patterns

Security Considerations

none

Scaling Considerations

By allowing want patterns, might this make the processing of wants more expensive?

Documentation Considerations

Need to update the Zoe API docs to explain want-patterns

Testing Considerations

• Need to add Zoe tests once the Zoe changes are in

Upgrade Considerations

None

• Need to update NEWS.md for Zoe

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	9b970c3
Status:	🚫  Build failed.

View logs

[github-actions]

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

[Copilot]

Pull Request Overview

This PR implements minimal want patterns support in Zoe, allowing the use of M.containerHas(el,n) patterns in proposal wants. The implementation focuses on the Zoe-side infrastructure needed to handle amount bounds (patterns) rather than just exact amounts in proposal wants.

Key changes:

• Updates type definitions to distinguish between Amount and AmountBound types
• Modifies proposal processing to support patterns in want clauses while maintaining backwards compatibility
• Adds infrastructure for pattern validation and conversion

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/zoe/tools/setup-zoe.js	Updates import organization for Installation type
packages/zoe/test/unitTests/zoe/escrowStorage.test.js	Adds mock getAssetKindByBrand function parameter to test calls
packages/zoe/test/unitTests/setupBasicMints.js	Replaces AmountMath.make with direct amount construction and updates type annotations
packages/zoe/test/unitTests/cleanProposal.test.js	Updates tests to use M.containerHas patterns instead of M.any()
packages/zoe/test/types.test-d.ts	Reorganizes type imports for Installation
packages/zoe/src/zoeService/zoeStorageManager.js	Passes getAssetKindByBrand function to provideEscrowStorage
packages/zoe/src/zoeService/types.ts	Major type reorganization introducing AmountBound types and consolidating imports
packages/zoe/src/zoeService/internal-types.js	Updates type imports and references
packages/zoe/src/zoeService/escrowStorage.js	Adds getAssetKindByAmount helper and updates empty amount creation
packages/zoe/src/types.ts	Minor import reorganization
packages/zoe/src/typeGuards.js	Replaces AmountPatternKeywordRecordShape with AmountBoundKeywordRecordShape
packages/zoe/src/contracts/loan/borrow.js	Adds type assertions and pattern validation for amounts
packages/zoe/src/contracts/auction/secondPriceLogic.js	Adds type assertion for brand
packages/zoe/src/contracts/auction/firstPriceLogic.js	Adds type assertion for brand
packages/zoe/src/contractSupport/zoeHelpers.js	Adds mustBeKey helper and updates swapExact to handle amount bounds
packages/zoe/src/contractSupport/atomicTransfer.js	Updates to support AmountBound types in transfer operations
packages/zoe/src/contractFacet/types.ts	Updates TransferPart type to use AmountBoundKeywordRecord
packages/zoe/src/contractFacet/reallocate.js	Adds pattern validation for transfer amounts
packages/zoe/src/contractFacet/offerSafety.js	Updates to work with AmountBound types
packages/zoe/src/cleanProposal.js	Major refactoring to support AmountBound validation and M.containerHas patterns

[Copilot]

The change from returning resultingAllocations to harden(resultingAllocations) suggests the original array wasn't hardened. This should be verified against the function's return type expectations and existing callers to ensure compatibility.

[Copilot]

[nitpick] The function parameter is named want but the function is generic and could be used for other purposes. Consider renaming to value or input for better clarity.

Suggested change

	* @param {AmountBoundKeywordRecord} want
	* @param {string} complaint
	* @returns {AmountKeywordRecord}
	*/
	export const mustBeKey = (want, complaint) => {
	if (isKey(want)) {
	return want;
	}
	if (isPattern(want)) {
	throw Fail`${b(complaint)}: ${want}`;
	}
	throw Fail`Must be key: ${want}`;
	* @param {AmountBoundKeywordRecord} value
	* @param {string} complaint
	* @returns {AmountKeywordRecord}
	*/
	export const mustBeKey = (value, complaint) => {
	if (isKey(value)) {
	return value;
	}
	if (isPattern(value)) {
	throw Fail`${b(complaint)}: ${value}`;
	}
	throw Fail`Must be key: ${value}`;

[Copilot]

"atomicRearange" should be "atomicRearrange" (missing 'r').

Suggested change

	'TODO: atomicRearange does not yet support AmountBounds',
	'TODO: atomicRearrange does not yet support AmountBounds',