feat(ertp): ertp-only part of minimal want-patterns #11235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
979da2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0caa23d4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-want-patterns-only-ert.agoric-sdk.pages.dev |
3 tasks
erights
force-pushed
the
markm-want-patterns-only-ertp
branch
from
ae6b40c to
2e4d932
Compare
erights
force-pushed
the
markm-want-patterns-only-ertp
branch
from
2e4d932 to
979da2a
Compare
erights
commented
Apr 8, 2025
| @@ -116,7 +116,7 @@ export const makeRatioFromAmounts = (numeratorAmount, denominatorAmount) => { | |||
| * @returns {Amount<'nat'>} | |||
| */ | |||
| const multiplyHelper = (amount, ratio, divideOp) => { | |||
| AmountMath.coerce(amount.brand, amount); | |||
| amount = AmountMath.coerce(amount.brand, amount); | |||
There was a problem hiding this comment.
A drive-by. coerce only produces a valid output from valid or almost-valid input. It does not validate or modify the input. So either we should use the result of coerce or we should remove it. Not sure yet whether this coerce is actually needed.
erights
commented
Apr 8, 2025
| @@ -0,0 +1,60 @@ | |||
| import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js'; | |||
| import { M, makeCopySet } from '@endo/patterns'; | |||
|
|
|||
There was a problem hiding this comment.
TODO do we also need a copyBagBoundMathHelpers.test.js?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: endojs/endo#2710 #1905 #1913 #1915 #2155 #2156 #2230 #4212 #4217 #10951 #10952
Description
Implements the ERTP part of minimal want patterns, where the only supported pattern is
M.containerHas. #10952 then implements the zoe portion.Security Considerations
none
Scaling Considerations
at the ERTP level, none.
Documentation Considerations
Need to update ERTP docs to explain the use of
M.haspatterns inAmountMath.isGTEandAmountMath.subtract.Testing Considerations
ERTP tests already added.
Upgrade Considerations
None