Split DefaultTaskEvents in process engine into smaller interfaces and classes #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// <inheritdoc/> | ||
| public async Task Initialize(string taskId, Instance instance, Dictionary<string, string> prefill) | ||
| { | ||
| _logger.LogDebug("OnStartProcessTask for {InstanceId}", instance.Id); |
Check failure
Code scanning / CodeQL
Log entries created from user input
src/Altinn.App.Core/Internal/Process/ProcessTasks/Common/ProcessTaskFinalizer.cs
Fixed
Show fixed
Hide fixed
bjorntore
force-pushed
the
feat/refactor-process-engine-split-default-task-events
branch
2 times, most recently
from
6a14cf9 to
d0dacb0
Compare
ivarne
reviewed
Mar 5, 2024
ivarne
reviewed
Mar 5, 2024
src/Altinn.App.Core/Internal/Process/ServiceTasks/Interfaces/IServiceTask.cs
Show resolved
Hide resolved
ivarne
reviewed
Mar 5, 2024
bjorntore
force-pushed
the
feat/refactor-process-engine-split-default-task-events
branch
3 times, most recently
from
39e7175 to
df559f6
Compare
bjorntore
force-pushed
the
feat/refactor-process-engine-split-default-task-events
branch
from
df559f6 to
9c2729d
Compare
tjololo
approved these changes
Mar 12, 2024
src/Altinn.App.Core/Internal/Process/ServiceTasks/EformidlingServiceTask.cs
Outdated
Show resolved
Hide resolved
src/Altinn.App.Core/Internal/Process/ServiceTasks/PdfServiceTask.cs
Outdated
Show resolved
Hide resolved
bjorntore
force-pushed
the
feat/refactor-process-engine-split-default-task-events
branch
from
9c2729d to
bdbc745
Compare
… classes. Restructuring of process task handling in general.
bjorntore
force-pushed
the
feat/refactor-process-engine-split-default-task-events
branch
from
bdbc745 to
01e2fa3
Compare
|
bjorntore
deleted the
feat/refactor-process-engine-split-default-task-events
branch
5 tasks
ivarne
added
the
breaking-change
3 tasks
bjorntore
removed
the
breaking-change
Contributor
Author
|
Removing breaking-change label due to #613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split DefaultTaskEvents in process engine into smaller interfaces and classes. Restructuring of process task handling in general.
Description
Most of the process task related functionality was implemented in one class. Splitting it up and laying the grounds for more advanced process tasks to come in the near future. Payment etc.
Related Issue(s)
Verification
Documentation