Skip to content

Conversation

@bjorntore
Copy link
Contributor

Looked through dfd5cff and tried to spot any breaking change of consequence.

Reverting "Success" property that was removed from UserActionResult.

Other than that I used @ivarne's tool to download all TE repos and used VS Code to search for these interfaces and classes, which have been removed in the commit:

ITaskEvents
DefaultTaskEvents
ITask
TaskBase
ConfirmationTask
DataTask
FeedbackTask
NullTask

I didn't find any usage of these in TE code.
I also checked some of the integral classes in the process engine code, without finding any.

I took a couple of the applications that had done custom stuff using the process engine (UserAction, IProcessStart, IProcessEnd) and upped the version number to https://github.com/Altinn/app-lib-dotnet/releases/tag/v8.1.0-preview.6 and built successfully.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • All tests run green

@bjorntore bjorntore requested review from RonnyB71 and ivarne April 24, 2024 10:18
@bjorntore bjorntore self-assigned this Apr 24, 2024
@sonarqubecloud
Copy link

@ivarne ivarne added this to the 8.1.0 milestone Apr 24, 2024
@bjorntore bjorntore merged commit dd0de6c into main Apr 24, 2024
@bjorntore bjorntore deleted the feat/471-default-task-events-refactor-revert-breaking-changes branch April 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants