Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsaacSim 4.1.0 python packages compatibility #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TL-4319
Copy link

@TL-4319 TL-4319 commented Nov 1, 2024

This PR add "empy" in IsaacSim 2023.1.1 and "lark" in IsaacSim 4.1.0 python env to suppress warning about not being able to find them. The PR also downgrade "numpy" preinstalled with IsaacSim 4.1.0 to version 1.22.0 to fix compatibility with numpy used by OmniLRS. Changes are made in documentaion README as well as the installation script for native installation.

… package and downgrade numpy to 1.22.0 for compatibility with OmniLRS for IsaacSim 4.1.0
~/.local/share/ov/pkg/isaac_sim-2023.1.1/python.sh -m pip install opencv-python omegaconf hydra-core skyfield gdal==$version zfpy numba
~/.local/share/ov/pkg/isaac-sim-2023.1.1/python.sh -m pip install opencv-python omegaconf hydra-core skyfield gdal==$version zfpy numba empy
Copy link
Owner

@AntoineRichard AntoineRichard Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of them could be valid, Nvidia changed the path to 2023.1.1, depends on how old your 2023.1.1 install is.

I would reformat to have both:

~/.local/share/ov/pkg/isaac-sim-2023.1.1/python.sh -m pip install opencv-python omegaconf hydra-core skyfield gdal==$version zfpy numba empy
# If this does not work for you, you may be running an old version of Isaac 2023.1.1, you may need to run the following:
# ~/.local/share/ov/pkg/isaac_sim-2023.1.1/python.sh -m pip install opencv-python omegaconf hydra-core skyfield gdal==$version zfpy numba

Copy link
Owner

@AntoineRichard AntoineRichard Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To enable the installation on systems with multiple Isaac Version, it may be better to use a flag to enable the 4.1.0 installation.

Maybe something like that:

At the beginning, add:

USE_ISAAC_V4=false
while getopts 'v' opt; do
        case $opt in
                v) USE_ISAAC_V4=true;;
                *) echo 'Erro in command line parsing' >&2
                   exit 1
        esac
done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script/install_native.sh -v would trigger a V4.1 install.

Copy link
Owner

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the edits :). It looks good to me, but one small thing is that it will favor 2023.1.1 over 4.1 if both are installed. I suggested some changes to fix that.

@TL-4319
Copy link
Author

TL-4319 commented Nov 5, 2024

Hi, I have include your suggested changes into install script and update the Readme to reflect them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants