UAVCAN parameters with a text value can now be saved to file and load…

.editorconfig

@@ -55,3 +55,8 @@ dotnet_diagnostic.CS1522.severity = suggestion
 
 dotnet_diagnostic.CS3021.severity = silent
 dotnet_diagnostic.CS0618.severity = silent
+
+# AsyncVoidAnalyzer: Async Void methods should catch exceptions
+dotnet_diagnostic.AsyncVoidAnalyzer.severity = error
+
+dotnet_diagnostic.ASYNC0003.severity = error

.gitignore

@@ -36,3 +36,5 @@ docs/
 *.Test/
 *.jar
 *.cache
+/Plugins/Dowding/server/node_modules
+/Plugins/Dowding/server/package-lock.json

Controls/ConnectionControl.resx

@@ -180,7 +180,7 @@
     <value>15</value>
   </data>
   <data name="cmb_Baud.Size" type="System.Drawing.Size, System.Drawing">
-    <value>70, 28</value>
+    <value>111, 28</value>
   </data>
   <data name="cmb_Baud.TabIndex" type="System.Int32, mscorlib">
     <value>0</value>
@@ -228,7 +228,7 @@
     <value>True</value>
   </data>
   <data name="linkLabel1.Location" type="System.Drawing.Point, System.Drawing">
-    <value>3, 37</value>
+    <value>3, 32</value>
   </data>
   <data name="linkLabel1.Size" type="System.Drawing.Size, System.Drawing">
     <value>40, 13</value>
@@ -254,14 +254,11 @@
   <data name="&gt;&gt;linkLabel1.ZOrder" xml:space="preserve">
     <value>1</value>
   </data>
-  <data name="cmb_sysid.Font" type="System.Drawing.Font, System.Drawing">
-    <value>Microsoft Sans Serif, 12pt</value>
-  </data>
   <data name="cmb_sysid.Location" type="System.Drawing.Point, System.Drawing">
-    <value>49, 30</value>
+    <value>102, 27</value>
   </data>
   <data name="cmb_sysid.Size" type="System.Drawing.Size, System.Drawing">
-    <value>148, 28</value>
+    <value>136, 21</value>
   </data>
   <data name="cmb_sysid.TabIndex" type="System.Int32, mscorlib">
     <value>4</value>
@@ -282,10 +279,10 @@
     <value>True</value>
   </metadata>
   <data name="$this.MinimumSize" type="System.Drawing.Size, System.Drawing">
-    <value>200, 60</value>
+    <value>200, 47</value>
   </data>
   <data name="$this.Size" type="System.Drawing.Size, System.Drawing">
-    <value>200, 60</value>
+    <value>238, 47</value>
   </data>
   <data name="&gt;&gt;$this.Name" xml:space="preserve">
     <value>ConnectionControl</value>

Controls/MavFTPUI.cs

@@ -86,25 +86,25 @@ private async void PopulateTreeView()
             {
                 rootNode = new TreeNode(info.Name, 0, 0);
                 rootNode.Tag = info;
-                await GetDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
+                await PopulateDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
                 treeView1.Nodes.Add(rootNode);
             }
-
+            /*
             info = new DirectoryInfo(@"@ROMFS/", _mavftp);
             if (info.Exists)
             {
                 rootNode = new TreeNode("@ROMFS", 0, 0);
                 rootNode.Tag = info;
-                await GetDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
+                await PopulateDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
                 treeView1.Nodes.Add(rootNode);
             }
-
+            */
             info = new DirectoryInfo(@"@SYS/", _mavftp);
             if (info.Exists)
             {
                 rootNode = new TreeNode("@SYS", 0, 0);
                 rootNode.Tag = info;
-                await GetDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
+                await PopulateDirectories(await info.GetDirectories().ConfigureAwait(true), rootNode).ConfigureAwait(true);
                 treeView1.Nodes.Add(rootNode);
             }
 
@@ -122,7 +122,7 @@ private async void PopulateTreeView()
             TreeView1_NodeMouseClick(this, new TreeNodeMouseClickEventArgs(rootNode, MouseButtons.Left, 1, 1, 1));
         }
 
-        private async Task GetDirectories(DirectoryInfo[] subDirs,
+        private async Task PopulateDirectories(DirectoryInfo[] subDirs,
             TreeNode nodeToAddTo)
         {
             List<TreeNode> info = new List<TreeNode>();
@@ -152,7 +152,7 @@ private async void TreeView1_NodeMouseClick(object sender, TreeNodeMouseClickEve
 
             newSelected.Nodes.Clear();
 
-            await GetDirectories(dirs, newSelected).ConfigureAwait(true);
+            await PopulateDirectories(dirs, newSelected).ConfigureAwait(true);
 
             foreach (DirectoryInfo dir in dirs)
             {
@@ -217,25 +217,44 @@ public override void Delete()
 
             public async Task<DirectoryInfo[]> GetDirectories()
             {
-                // rerequest every time
-                await Task.Run(() =>
+                try
                 {
-                    lock (_mavftp)
+                    // rerequest every time
+                    await Task.Run(() =>
                     {
-                        cache = _mavftp.kCmdListDirectory(FullPath, new CancellationTokenSource());
-                    }
-                }).ConfigureAwait(true);
-                return cache.Where(a => a.isDirectory && a.Name != "." && a.Name != "..")
-                    .Select(a => new DirectoryInfo(a.FullName, _mavftp)).ToArray();
+                        lock (_mavftp)
+                        {
+                            cache = _mavftp.kCmdListDirectory(FullPath, new CancellationTokenSource());
+                        }
+                    }).ConfigureAwait(true);
+                    return cache.Where(a => a.isDirectory && a.Name != "." && a.Name != "..")
+                        .Select(a => new DirectoryInfo(a.FullName, _mavftp)).ToArray();
+
+                }
+                catch (Exception e)
+                {
+                    log.Error(e);
+                }
+
+                return new DirectoryInfo[] { };
             }
 
             public async Task<IEnumerable<MAVFtp.FtpFileInfo>> GetFiles()
             {
-                if (cache == null)
-                    await GetDirectories().ConfigureAwait(true);
+                try
+                {
+                    if (cache == null)
+                        await GetDirectories().ConfigureAwait(true);
+
+                    // rerequest every time
+                    return cache.Where(a => !a.isDirectory);
+                }
+                catch (Exception e)
+                {
+                    log.Error(e);
+                }
 
-                // rerequest every time
-                return cache.Where(a => !a.isDirectory);
+                return new List<MAVFtp.FtpFileInfo>();
             }
         }
 
@@ -245,7 +264,15 @@ private async void ListView1_DragDrop(object sender, DragEventArgs e)
 
             foreach (var file in files)
             {
-                await UploadFile(file).ConfigureAwait(true);
+                try
+                {
+                    await UploadFile(file).ConfigureAwait(true);
+                }
+                catch (Exception exception)
+                {
+                    log.Error(exception);
+                    CustomMessageBox.Show(exception.Message);
+                }
             }
 
             TreeView1_NodeMouseClick(null,
@@ -315,15 +342,6 @@ private async void DownloadToolStripMenuItem_Click(object sender, EventArgs e)
                         }
 
                         File.WriteAllBytes(sfd.FileName, ms.ToArray());
-
-                        prd.UpdateProgressAndStatus(-1, "Calc CRC");
-                        uint crc = 0;
-                        _mavftp.kCmdCalcFileCRC32(path, ref crc, cancel);
-                        var crc32a = MAVFtp.crc_crc32(0, File.ReadAllBytes(sfd.FileName));
-                        if (crc32a != crc)
-                        {
-                            throw new BadCrcException();
-                        }
                     };
                     prd.RunBackgroundOperationAsync();
                     _mavftp.Progress -= progress;
@@ -346,7 +364,15 @@ private async void UploadToolStripMenuItem_Click(object sender, EventArgs e)
             {
                 foreach (var ofdFileName in ofd.FileNames)
                 {
-                    await UploadFile(ofdFileName).ConfigureAwait(true);
+                    try
+                    {
+                        await UploadFile(ofdFileName).ConfigureAwait(true);
+                    }
+                    catch (Exception exception)
+                    {
+                        log.Error(exception);
+                        CustomMessageBox.Show(exception.Message);
+                    }
                 }
             }
 
@@ -403,10 +429,24 @@ private void DeleteToolStripMenuItem_Click(object sender, EventArgs e)
             foreach (ListViewItem listView1SelectedItem in listView1.SelectedItems)
             {
                 toolStripStatusLabel1.Text = "Delete " + listView1SelectedItem.Text;
-                var success = _mavftp.kCmdRemoveFile(((DirectoryInfo)listView1SelectedItem.Tag).FullName + "/" +
-                                                     listView1SelectedItem.Text, new CancellationTokenSource());
-                if (!success)
-                    CustomMessageBox.Show("Failed to delete file", listView1SelectedItem.Text);
+                ProgressReporterDialogue prd = new ProgressReporterDialogue();
+                CancellationTokenSource cancel = new CancellationTokenSource();
+                prd.doWorkArgs.CancelRequestChanged += (o, args) =>
+                {
+                    prd.doWorkArgs.ErrorMessage = "User Cancel";
+                    cancel.Cancel();
+                    _mavftp.kCmdResetSessions();
+                };
+                prd.doWorkArgs.ForceExit = false;
+                prd.DoWork += (iprd) =>
+                {
+                    var success = _mavftp.kCmdRemoveFile(((DirectoryInfo) listView1SelectedItem.Tag).FullName + "/" +
+                                                         listView1SelectedItem.Text, cancel);
+                    if (!success)
+                        CustomMessageBox.Show("Failed to delete file", listView1SelectedItem.Text);
+                };
+
+                prd.RunBackgroundOperationAsync();
             }
 
             TreeView1_NodeMouseClick(null,
@@ -423,10 +463,24 @@ private void ListView1_AfterLabelEdit(object sender, LabelEditEventArgs e)
         {
             if (e.Label == null)
                 return;
+            ProgressReporterDialogue prd = new ProgressReporterDialogue();
+            CancellationTokenSource cancel = new CancellationTokenSource();
+            prd.doWorkArgs.CancelRequestChanged += (o, args) =>
+            {
+                prd.doWorkArgs.ErrorMessage = "User Cancel";
+                cancel.Cancel();
+                _mavftp.kCmdResetSessions();
+            };
+            prd.doWorkArgs.ForceExit = false;
+            var selectedNodeFullPath = treeView1.SelectedNode.FullPath; 
+            var text = listView1.SelectedItems[0].Text;
+            prd.DoWork += (iprd) =>
+            {
+                _mavftp.kCmdRename(selectedNodeFullPath + "/" + text,
+                    selectedNodeFullPath + "/" + e.Label, cancel);
+            };
 
-            _mavftp.kCmdRename(treeView1.SelectedNode.FullPath + "/" + listView1.SelectedItems[0].Text,
-                treeView1.SelectedNode.FullPath + "/" + e.Label, new CancellationTokenSource());
-
+            prd.RunBackgroundOperationAsync();
             TreeView1_NodeMouseClick(null,
                 new TreeNodeMouseClickEventArgs(treeView1.SelectedNode, MouseButtons.Left, 1, 1, 1));
             toolStripStatusLabel1.Text = "Ready";
@@ -437,11 +491,27 @@ private void NewFolderToolStripMenuItem_Click(object sender, EventArgs e)
             string folder = "";
             var dr = InputBox.Show("Folder Name", "Enter folder name", ref folder);
             if (dr == DialogResult.OK)
-                if (!_mavftp.kCmdCreateDirectory(treeView1.SelectedNode.FullPath + "/" + folder,
-                    new CancellationTokenSource()))
+            {
+                ProgressReporterDialogue prd = new ProgressReporterDialogue();
+                CancellationTokenSource cancel = new CancellationTokenSource();
+                prd.doWorkArgs.CancelRequestChanged += (o, args) =>
                 {
-                    CustomMessageBox.Show("Failed to create directory", Strings.ERROR);
-                }
+                    prd.doWorkArgs.ErrorMessage = "User Cancel";
+                    cancel.Cancel();
+                    _mavftp.kCmdResetSessions();
+                };
+                prd.doWorkArgs.ForceExit = false;
+                prd.DoWork += (iprd) =>
+                {
+                    if (!_mavftp.kCmdCreateDirectory(treeView1.SelectedNode.FullPath + "/" + folder,
+                        cancel))
+                    {
+                        CustomMessageBox.Show("Failed to create directory", Strings.ERROR);
+                    }
+                };
+
+                prd.RunBackgroundOperationAsync();
+            }
 
             TreeView1_NodeMouseClick(null,
                 new TreeNodeMouseClickEventArgs(treeView1.SelectedNode, MouseButtons.Left, 1, 1, 1));
@@ -544,15 +614,6 @@ private void DownloadBurstToolStripMenuItem_Click(object sender, EventArgs e)
                         }
 
                         File.WriteAllBytes(sfd.FileName, ms.ToArray());
-
-                        prd.UpdateProgressAndStatus(-1, "Calc CRC");
-                        uint crc = 0;
-                        _mavftp.kCmdCalcFileCRC32(path, ref crc, cancel);
-                        var crc32a = MAVFtp.crc_crc32(0, File.ReadAllBytes(sfd.FileName));
-                        if (crc32a != crc)
-                        {
-                            throw new BadCrcException();
-                        }
                     };
                     prd.RunBackgroundOperationAsync();
                     _mavftp.Progress -= progress;