mavcmd: add do-set-roi-location and do-set-roi-none #3507
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
force-pushed
the
mavcmd-roi-location
branch
from
985b2a1 to
85e7fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds DO_SET_ROI_LOCATION and DO_SET_ROI_NONE to the list of available mission commands for Copter, Rover and Plane.
This has been lightly tested in SITL and seems fine except that the red marker does not appear on the map like it does for the older DO_SET_ROI command. Maybe @EosBandi, @robertlong13 or @meee1 could tell me where I could update to fix this? I suspect there's just some case statement that's missing an entry for DO_SET_ROI_LOCATION.
The corresponding AP flight code PR is here ArduPilot/ardupilot#29567