This repository was archived by the owner on Oct 1, 2021. It is now read-only.
PX4FMU::sensor_reset method fix #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als after rest performed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it restore ok MOSI/MISO/SCK signals after reset performed.
Without this fix the 'fmu sensor_rest' command makes SPI communications broken.
Fix has been tested, it works.
It has been implemented during investigation of BAD ACCEL HEALTH problem. I can see you have it already applied to master branch, but not to Copter-3.3 branch.
https://github.com/diydrones/PX4Firmware/blame/master/src/drivers/px4fmu/fmu.cpp#L1495-L1497
It is an important fix to resolve BAD ACCEL HEALTH in Copter-3.3.
Details are here: http://diydrones.com/forum/topics/solution-proposal-for-pixhawk-imu2-related-bad-accell-health
Also it has been discussed with Lorenz Meier here: https://groups.google.com/forum/#!msg/px4users/Ek8D5hRZeIs/dWvDyZs-BAAJ
Thank you in advance,
Dmitry Prokhorov