Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SITL viewer model #51

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Apr 20, 2024

Purpose

Add a new model for the purpose of a SITL viewer. Work-in-progress.

Issue

Relates to ArduPilot/ardupilot_gazebo#90

Signed-off-by: Ryan Friedman <[email protected]>
@@ -0,0 +1,135 @@
cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is for system plugins such as the SitlViewer to go under ardupilot_gz_gazebo/src in their own sub-folder. This is how gz-sim is organised, where there is a gz-sim/src/systems directory. ardupilot_gz_gazebo already has hooks, so should install any system plugins to the appropriate {workpace}/install location.

The supplied examples (from the template) should really be under src/systems/basic_system and src/systems/full_system. They can be relocated as a separate PR to make the intent clearer.

@@ -0,0 +1,4 @@
prepend-non-duplicate;GZ_SIM_RESOURCE_PATH;share;@CMAKE_INSTALL_PREFIX@/share
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate hooks should not be required if ardupilot_gz_gazebo is used.

@srmainwaring
Copy link
Collaborator

srmainwaring commented Apr 26, 2024

@Ryanf55 I've started to scan through this. Can you add a launch file to run the example or add the command required to get ArduPilot SITL and the viewer running to the README.

Update

Manage to get the node running. Getting this output (not working correctly):

sitl-viewer.mov

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Apr 27, 2024

@Ryanf55 I've started to scan through this. Can you add a launch file to run the example or add the command required to get ArduPilot SITL and the viewer running to the README.

Update

Manage to get the node running. Getting this output (not working correctly):

sitl-viewer.mov

Yep! Do you think the approach of using gazebo transport is good, or would it be better to use a plugin instead? The key advantage of a plugin would be the ability to do lockstep, but I think for the purpose of a minimal demo, a dedicated ROS node that uses gz transport is simpler code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants