-
Notifications
You must be signed in to change notification settings - Fork 657
DFReader pandas module #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DFReader pandas module #1032
Conversation
5913725
to
b86415e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this should be in top level
dfreader_pandas.py
Outdated
@@ -0,0 +1,215 @@ | |||
""" | |||
Module to parse ArduPilot logs into pandas DataFrames with optional caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be in tools/ or examples/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's out of place at top level for sure. I do want it to be importable though, like from pymavlink.tools.dfreader_pandas import parse_log_to_df
. I'll figure out how to do that. I think that means I need to add tools to packages, which now that I say it, is probably better than installing all these tools as scripts. We should be calling them like python -m pymavlink.tools.magfit
Turns out I don't need to do anything, that can already be done
52c6a8b
to
58fda91
Compare
ef4b093
to
6d7166f
Compare
@robertlong13 looks good, just needs to be out of draft to merge |
WIP
I was tempted to make this as a totally separate repo, but maybe it's the right fit here. Opening a draft PR in case anyone else is interested in it.
This is handy for writing analysis scripts and jupyter notebooks. It resamples all your fields of interest to a common time base and returns everything together as a pandas dataframe. I also have it cache that dataframe so that you can quickly rerun your scripts during development without needing to handle caching manually.