Skip to content

DFReader pandas module #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robertlong13
Copy link
Contributor

WIP

I was tempted to make this as a totally separate repo, but maybe it's the right fit here. Opening a draft PR in case anyone else is interested in it.

This is handy for writing analysis scripts and jupyter notebooks. It resamples all your fields of interest to a common time base and returns everything together as a pandas dataframe. I also have it cache that dataframe so that you can quickly rerun your scripts during development without needing to handle caching manually.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this should be in top level

@@ -0,0 +1,215 @@
"""
Module to parse ArduPilot logs into pandas DataFrames with optional caching.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in tools/ or examples/

Copy link
Contributor Author

@robertlong13 robertlong13 May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's out of place at top level for sure. I do want it to be importable though, like from pymavlink.tools.dfreader_pandas import parse_log_to_df. I'll figure out how to do that. I think that means I need to add tools to packages, which now that I say it, is probably better than installing all these tools as scripts. We should be calling them like python -m pymavlink.tools.magfit

Turns out I don't need to do anything, that can already be done

@robertlong13 robertlong13 force-pushed the pr/dfreader_pandas branch 3 times, most recently from 52c6a8b to 58fda91 Compare May 22, 2025 01:12
@tridge tridge force-pushed the pr/dfreader_pandas branch from ef4b093 to 6d7166f Compare July 19, 2025 08:10
@tridge
Copy link
Contributor

tridge commented Jul 19, 2025

@robertlong13 looks good, just needs to be out of draft to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants