mavgen_objc.py: rename BOOL to MAV_BOOL #1098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer MAV_BOOL |
generator/mavgen_objc.py
Outdated
| @@ -45,7 +45,7 @@ def generate_mavlink(directory, xml): | |||
| @param mavlink The MVMavlink object calling this method | |||
| @param data NSData object containing the bytes to be sent | |||
| */ | |||
| - (BOOL)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; | |||
| - (MAV_OPTION)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; | |||
There was a problem hiding this comment.
Suggested change
| - (MAV_OPTION)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; | |
| - (MAV_BOOL)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; |
generator/mavgen_objc.py
Outdated
| @@ -70,7 +70,7 @@ def generate_mavlink(directory, xml): | |||
| @param message Object conforming to the MVMessage protocol that represents the data to be sent | |||
| @return YES if message sending was successful | |||
| */ | |||
| - (BOOL)sendMessage:(id<MVMessage>)message; | |||
| - (MAV_OPTION)sendMessage:(id<MVMessage>)message; | |||
There was a problem hiding this comment.
Suggested change
| - (MAV_OPTION)sendMessage:(id<MVMessage>)message; | |
| - (MAV_BOOL)sendMessage:(id<MVMessage>)message; |
generator/mavgen_objc.py
Outdated
| @@ -103,7 +103,7 @@ def generate_mavlink(directory, xml): | |||
| } | |||
| } | |||
|
|
|||
| - (BOOL)sendMessage:(id<MVMessage>)message { | |||
| - (MAV_OPTION)sendMessage:(id<MVMessage>)message { | |||
There was a problem hiding this comment.
Suggested change
| - (MAV_OPTION)sendMessage:(id<MVMessage>)message { | |
| - (MAV_BOOL)sendMessage:(id<MVMessage>)message { |
andrewvoznytsa
force-pushed
the
rename-bool-to-mav_option
branch
from
7624af9 to
9887623
Compare
|
Renamed MAV_OPTION to MAV_BOOL |
peterbarker
approved these changes
Jul 23, 2025
peterbarker
changed the title
|
@peterbarker Thanks, but can you merge it too - or give me rights to merge things that are already approved. |
| @@ -45,7 +45,7 @@ def generate_mavlink(directory, xml): | |||
| @param mavlink The MVMavlink object calling this method | |||
| @param data NSData object containing the bytes to be sent | |||
| */ | |||
| - (BOOL)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; | |||
| - (MAV_BOOL)mavlink:(MVMavlink *)mavlink shouldWriteData:(NSData *)data; | |||
There was a problem hiding this comment.
So this this already support the BOOL enum we added? My assumption is that it did and this is why you need to change it? That was a quick addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mavlink/mavlink#2317 initiative.