-
Notifications
You must be signed in to change notification settings - Fork 0
use pie-core
instead of pytorch-ie
(core only, not for datasets)
#178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArneBinder
wants to merge
19
commits into
main
Choose a base branch
from
use_pie_core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2025
pie-core
and pie-modules instead of pytorch-ie
This was referenced Apr 8, 2025
pie-core
and pie-modules instead of pytorch-ie
pie-core
and pie-modules
instead of pytorch-ie
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage ? 92.52%
=======================================
Files ? 10
Lines ? 963
Branches ? 0
=======================================
Hits ? 891
Misses ? 72
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b384e3c
to
8150404
Compare
pie-core
and pie-modules
instead of pytorch-ie
pie-core
and pie-modules
instead of pytorch-ie
(core only)
6 tasks
pie-core
and pie-modules
instead of pytorch-ie
(core only)pie-core
(and pie-modules
) instead of pytorch-ie
(core only)
pie-core
(and pie-modules
) instead of pytorch-ie
(core only)pie-core
(and pie-modules
) instead of pytorch-ie
(core only, not for datasets)
pie-core
(and pie-modules
) instead of pytorch-ie
(core only, not for datasets)pie-core
instead of pytorch-ie
(core only, not for datasets)
…, ExitDatasetMixin implementations, but use them from pie-core
254a1fd
to
7f25ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also:
EnterDatasetMixin
,ExitDatasetMixin
,EnterDatasetDictMixin
, andExitDatasetDictMixin
from pytorch-ie (or pie-core) #174requires:
TransformerSpanClassificationTaskModule
frompytorch-ie
#180pie_modules.utils.sequence_tagging
#179pie-modules
including usepie-core
implicitly pie-modules#176:pie_modules
are derived frompie_core.Document
TODO:
pie-core
implicitly pie-modules#176BinaryRelation
,LabeledMultiSpan
,LabeledSpan
andTextBasedDocument
with Brat variantspie-modules
version below fixtoken_based_document_to_text_based
/text_based_document_to_token_based
for dependent predicted annotations pie-modules#135resolve_parts_of_same
variant becauseSpansViaRelationMerger
requires spans of typeLabeledSpan
, but we now useBratSpan
s in theBratDocument
sSpansViaRelationMerger
Follow-ups:
pie-core
in dataset builders #184torch
from dev dependencies (requires removepytorch-lightning
dependency pie-core#52)context: ArneBinder/pie-core#17