Skip to content

use pie-core in dataset builders #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Apr 17, 2025

This PR is the follow-up of #178. This is not breaking since the versioning of the dataset builders (this PR causes indeed breaking changes for some) is not handled by the pie-dataset, but rather via revisions on the Huggingface Hub.

requires:

TODO: for all individual dataset loaders and respective tests

  • switch to versions of pie-modules and pie-datasets that use pie-core
  • use Annotation, Document, etc. from pie-core (use AnnotationLayer instead if AnnotationList)
  • use annotations, documents, etc from pie-modules
  • switch to releases of pie-modules and pie-datasets when available

context: ArneBinder/pie-core#17

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (61575b4) to head (c77a268).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   93.41%   97.56%   +4.15%     
==========================================
  Files          10       18       +8     
  Lines         926     1314     +388     
==========================================
+ Hits          865     1282     +417     
+ Misses         61       32      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArneBinder ArneBinder force-pushed the use_pie_core_for_datasets branch from 0acbecd to c77a268 Compare April 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant