Skip to content

chain fix + qol

chain fix + qol #351

Triggered via pull request April 10, 2024 21:04
Status Failure
Total duration 3m 46s
Artifacts

main.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 9 warnings
this `let...else` may be rewritten with the `?` operator: unreal_asset/unreal_asset_base/src/unversioned/mod.rs#L227
error: this `let...else` may be rewritten with the `?` operator --> unreal_asset/unreal_asset_base/src/unversioned/mod.rs:227:9 | 227 | / let Some(parent) = ancestry.get_parent() else { 228 | | return None; 229 | | }; | |__________^ help: replace it with: `let parent = ancestry.get_parent()?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
function cannot return without recursing: unreal_asset/unreal_asset_base/src/types/fname.rs#L247
error: function cannot return without recursing --> unreal_asset/unreal_asset_base/src/types/fname.rs:247:5 | 247 | / fn eq(&self, other: &String) -> bool { 248 | | self == other 249 | | } | |_____^ | note: recursive call site --> unreal_asset/unreal_asset_base/src/types/fname.rs:248:9 | 248 | self == other | ^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion = note: `-D clippy::unconditional-recursion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unconditional_recursion)]`
this `let...else` may be rewritten with the `?` operator: unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs#L714
error: this `let...else` may be rewritten with the `?` operator --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:714:9 | 714 | / let Some(store_place) = self.key_map.get(key) else { 715 | | return None; 716 | | }; | |__________^ help: replace it with: `let store_place = self.key_map.get(key)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
this `let...else` may be rewritten with the `?` operator: unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs#L698
error: this `let...else` may be rewritten with the `?` operator --> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:698:9 | 698 | / let Some(store_place) = self.index_map.get(&index) else { 699 | | return None; 700 | | }; | |__________^ help: replace it with: `let store_place = self.index_map.get(&index)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `-D clippy::question-mark` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
read amount is not handled: unreal_asset/unreal_asset_base/src/containers/chain.rs#L62
error: read amount is not handled --> unreal_asset/unreal_asset_base/src/containers/chain.rs:62:33 | 62 | ... first.as_slice().read(buf)? | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use `Read::read_exact` instead, or handle partial reads = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount = note: `#[deny(clippy::unused_io_amount)]` on by default
build
could not compile `unreal_asset_base` (lib) due to 6 previous errors
build
Clippy had exited with the 101 exit code
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
Unexpected input(s) 'token', valid inputs are ['command', 'toolchain', 'args', 'use-cross']
build
the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4
build
Unexpected input(s) 'token', valid inputs are ['command', 'toolchain', 'args', 'use-cross']