Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreal_asset: add support for NON_OUTER_PACKAGE_IMPORT #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jariz
Copy link

@jariz jariz commented Apr 14, 2024

See #105

@konsti219 konsti219 requested a review from localcc April 14, 2024 14:29
Copy link
Contributor

@localcc localcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a write implementation and tests for an affected asset added.

@jariz
Copy link
Author

jariz commented Apr 14, 2024

Unfortunately it seems that the asset I was working with wasn't actually using this feature.
I have no idea how a import can reference a a external asset in any other way though, FModel gathers the following from it:

      "MediaList": [
        {
          "ObjectName": "AkMediaAsset'267782866'",
          "ObjectPath": "PenDriverPro/Content/WwiseAudio/Media/267782866.0"
        }

which clearly looks like a import from a different asset to me.

Anyway, if someone can deliver such an example asset, I'd be fine with writing the test and a write implementation to not let my effort go to waste completely, but until then, can't really finish this I guess.

@localcc
Copy link
Contributor

localcc commented Apr 14, 2024

Import can reference another asset through the import table iirc, so the field should just be a package index that is negative (meaning it is an import). And then the import table should contain the asset path that it references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants