EMSUSD-1570 add a class-prims filter to USD UFE #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1570/class-prims-in-outliner
branch
from
8c37fe1 to
25fcdea
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1570/class-prims-in-outliner
branch
from
25fcdea to
30aaaaf
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1570/class-prims-in-outliner
branch
from
30aaaaf to
5a880b7
Compare
| FilterSettings = collections.namedtuple('FilterSettings', ['filters', 'expecteditems']) | ||
| filterSettings = [ | ||
| FilterSettings( | ||
| filters={ 'InactivePrims': False, 'ClassPrims': False }, |
There was a problem hiding this comment.
This is my thinking, that a full list of possibilities may not be known in case there's a need to include all.
Perhaps we can document the supported filters somewhere to be used as a reference.
AramAzhari-adsk
previously approved these changes
Nov 7, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Nov 8, 2024
seando-adsk
reviewed
Nov 8, 2024
seando-adsk
removed
the
ready-for-merge
|
@pierrebai-adsk Removed the ready-for-merge just until my questions are answered. |
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1570/class-prims-in-outliner
branch
from
5a880b7 to
72fe93c
Compare
- Add a getUsdPredicate helper function to UsdUfe to create the USD predicate corresponding to a list of UFE filters. - Add the "Class Prims" filter to the list of USD filters in the hierarchy handler. - Use the helper to create the USD predicate. - Rely on the USD predicate having a correct predicate for inactive prim instead of using an explicit flag. - Adjust the context menu for class prims. - Add a unit test for the class prims filter. Work around the problem that Maya does not correctly handle UFE filters. Maya only handles one UFE filter. If there are more than one filters, only one is handled. To work around this issue, we manually ask the outliner what are the desired settings and use these settings as the default values for the filters. When the outliner fails to handle multiple filters, it will end-up using the default values, which will be the desired values. - Add a CMake compiler definition on the project. - The script to update the filter need to be protected from infinite recursion, no need to run it on idle. - Running it on idle would be making the filter new value not always being applied at the proper time. Easily visible when reload a scene.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1570/class-prims-in-outliner
branch
from
72fe93c to
22d2dd6
Compare
AramAzhari-adsk
approved these changes
Nov 11, 2024
|
I believe I answered Sean's concerns, so I'll mark this a ready for merge. |
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around the problem that Maya does not correctly handle UFE filters. Maya only handles one UFE filter. If there are more than one filters, only one is handled.
To work around this issue, we manually ask the outliner what are the desired settings and use these settings as the default values for the filters. When the outliner fails to handle multiple filters, it will end-up using the default values, which will be the desired values.