Detect the component creator if available#4368
Merged
seando-adsk merged 2 commits intodevfrom Nov 14, 2025
Merged
Conversation
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
7772c79 to
b6907fe
Compare
Collaborator
|
Hi @pierrebai-adsk , Do you want to test it after the install or its just an optional? |
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
b6907fe to
8b53ab6
Compare
Collaborator
Author
|
The component creator is optional. I need to modify the ecg repo to make it all work in the pipeline. |
samuelliu-adsk
previously approved these changes
Nov 3, 2025
pierrebai-adsk
added
ready-for-merge
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
8b53ab6 to
a6ab661
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
a6ab661 to
d077dde
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
d077dde to
be1ba9b
Compare
seando-adsk
reviewed
Nov 6, 2025
seando-adsk
reviewed
Nov 6, 2025
seando-adsk
reviewed
Nov 6, 2025
seando-adsk
reviewed
Nov 6, 2025
seando-adsk
reviewed
Nov 6, 2025
seando-adsk
reviewed
Nov 7, 2025
seando-adsk
requested changes
Nov 7, 2025
Collaborator
seando-adsk
left a comment
seando-adsk
left a comment
There was a problem hiding this comment.
Since the install of CC is done internally is there a need for this PR at this time?
Collaborator
Author
|
Anthon is working on the new save UI, so he will need access to the CC eventually. |
pierrebai-adsk
changed the title
Find the component creator and set CMake variables to its components. - Added `FindAdskUsdComponentCreator.cmake` CMake helper that finds the component creator. - It requires that a `ADSK_USD_COMPONENT_CREATOR_ROOT_DIR` env var or CMake var be set to the component creator install folder. - Find the component creator from the main CMakeLists.txt file. - Use standard library suffixes and prefixes to find libraries. - Added version report to be able to validate that we find the version. - Explicitly list the env var in hints.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2644/component-creator-integration
branch
from
91191b2 to
7978e7c
Compare
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
requested changes
Nov 12, 2025
Collaborator
seando-adsk
left a comment
seando-adsk
left a comment
There was a problem hiding this comment.
I'm not convinced that root_dir is something that should be set by this package. It is used by this package to find the CC pieces. What would be a use case for root_dir in other cmake files?
seando-adsk
removed
the
ready-for-merge
seando-adsk
added
shared_components
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
deleted the
bailp/EMSUSD-2644/component-creator-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find the component creator and set CMake variables to its components. Add it to the install target.
FindAdskUsdComponentCreator.cmakeCMake helper that finds the component creator.ADSK_USD_COMPONENT_CREATOR_ROOT_DIRenv var or CMake var be set to the component creator install folder.