-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stay on same tab when switching domains #97719
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~50 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
b0ee354
to
48e6c43
Compare
We made the decision not to support the subpages.
I researched the current feature state, and I understand that the Email tab is available for each domain. Discussion: p1735037561032999/1734725022.860659-slack-C082KU0C0MR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a small comment
return `/domains/manage/all/email/${ domain }/${ siteSlug }`; | ||
|
||
case 'domain-overview': | ||
default: | ||
return `/domains/manage/all/overview/${ domain }/${ siteSlug }`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the domainManagementAllRoot
here?
Closes #97446.
TODO:
Proposed Changes
Add
selectedFeature
prop to ensure UI stays on same tab when switching domains.Testing Instructions
calypso/all-domain-management
flag./domains/manage
, select a domain.calypso/all-domain-management
flag.Pre-merge Checklist