Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stay on same tab when switching domains #97719

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Dec 20, 2024

Closes #97446.

TODO:

  • Make it work with subpages like Email Forwarding (maybe? Check with Imran)
  • Is the Emails tab always guaranteed to be there for all sites? If not, account for that.
  • Add tests as needed
  • Nice to have: Make it scalable for any other tabs that may be added

Proposed Changes

Add selectedFeature prop to ensure UI stays on same tab when switching domains.

Testing Instructions

  • Enable the calypso/all-domain-management flag.
  • On /domains/manage, select a domain.
  • Click on the Emails tab.
  • Switch to a new domain.
  • Ensure the Emails tab is still selected.
  • Click on the Overview tab.
  • Switch to a new domain.
  • Ensure the Overview tab is still selected.
  • Disable the calypso/all-domain-management flag.
  • Click on different domains and ensure the functionality still works as before.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@donnapep donnapep self-assigned this Dec 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domain-switching-stay-on-same-tab on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~50 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
domains             +251 B  (+0.0%)      +50 B  (+0.0%)
site-overview       +129 B  (+0.0%)      +24 B  (+0.0%)
hosting             +129 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii force-pushed the fix/domain-switching-stay-on-same-tab branch from b0ee354 to 48e6c43 Compare December 24, 2024 11:31
@bogiii
Copy link
Contributor

bogiii commented Dec 24, 2024

Make it work with subpages like Email Forwarding (maybe? Check with Imran)

We made the decision not to support the subpages.

Is the Emails tab always guaranteed to be there for all sites? If not, account for that.

I researched the current feature state, and I understand that the Email tab is available for each domain.

Discussion: p1735037561032999/1734725022.860659-slack-C082KU0C0MR

@bogiii bogiii requested a review from a team December 24, 2024 11:34
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 24, 2024
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a small comment

Comment on lines +28 to +32
return `/domains/manage/all/email/${ domain }/${ siteSlug }`;

case 'domain-overview':
default:
return `/domains/manage/all/overview/${ domain }/${ siteSlug }`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the domainManagementAllRoot here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retain selected tab when domain is switched
4 participants