[servicebus] set receiver max listener limit to 1000 #19922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have done similar for the sender.
ghost
added
the
Member
Author
|
This is my understanding of the alternative change discussed in amqp/rhea-promise#78 (comment). |
| ): Promise<Receiver> { | ||
| return this._context.connection.createReceiver(options); | ||
| const receiver = await this._context.connection.createReceiver(options); | ||
| receiver.setMaxListeners(1000); |
Contributor
There was a problem hiding this comment.
Wouldn't the same be applicable to event-hubs?
And if possible, applying this logic at core-amqp might be more beneficial?
Member
Author
There was a problem hiding this comment.
Good point!
Connection lives in rhea-promise. I don't want to bump the limit there as other packages than EH and SB also depend on it. We could extend Connection in core-amqp.
Member
Author
|
Closing as alternative PR #20088 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues associated with this PR:
#12161
Describe the problem that is addressed by this PR:
During stress tests we are seeing warnings of
When many sessions on a connection are closed but the removal of the listener hasn't caught up, we will see this warning because the default limit of 10 in NodeJS is too low. The disconnected listeners DO get removed eventually.
This PR increases the max listener limiter for receiver to 1000. We have done similar for the sender.
What are the possible designs available to address the problem
Another proposal is in PR amqp/rhea-promise#78. It is however looks too complicated.
If there are more than one possible design, why was the one in this PR chosen?
This PR is simpler, and in line with what we are already doing for senders.