Skip to content

[servicebus] set receiver max listener limit to 1000 #19922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[servicebus] set receiver max listener limit to 1000 #19922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sdk/servicebus/service-bus/src/core/messageReceiver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,13 @@ export abstract class MessageReceiver extends LinkEntity<Receiver> {
}
}

protected createRheaLink(
protected async createRheaLink(
options: ReceiverOptions,
_abortSignal?: AbortSignalLike
): Promise<Receiver> {
return this._context.connection.createReceiver(options);
const receiver = await this._context.connection.createReceiver(options);
receiver.setMaxListeners(1000);
Copy link
Contributor

@HarshaNalluru HarshaNalluru Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the same be applicable to event-hubs?

And if possible, applying this logic at core-amqp might be more beneficial?

Copy link
Member Author

@jeremymeng jeremymeng Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Connection lives in rhea-promise. I don't want to bump the limit there as other packages than EH and SB also depend on it. We could extend Connection in core-amqp.

return receiver;
}

/**
Expand Down
6 changes: 4 additions & 2 deletions sdk/servicebus/service-bus/src/session/messageSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,13 @@ export class MessageSession extends LinkEntity<Receiver> {
}
}

protected createRheaLink(
protected async createRheaLink(
options: ReceiverOptions,
_abortSignal?: AbortSignalLike
): Promise<Receiver> {
return this._context.connection.createReceiver(options);
const receiver = await this._context.connection.createReceiver(options);
receiver.setMaxListeners(1000);
return receiver;
}

/**
Expand Down