Fix for File Share Limit Reached Error

[wonwuakpa-msft]

Description

• Changes:

  • Added nil and closure checks to ensure there's no panic from closing channels.
  • Added a description for the ShareSizeLimitReached error to guide users on how to handle the error
  • Added test to catch ShareSizeLimitReached error

• Feature / Bug Fix: (Brief description of the feature or issue being addressed)
  User reported this AzCopy behavior when uploading data to a file share that exceeds the quota (i.e uploading 4GB to a 1GB file share). When the quota is hit, the ongoing job is stopped and the already uploaded files are not deleted. AzCopy team concluded this is not a bug. There is a high chance of unnecessary failed API calls after the ShareSizeLimitReached error is hit. Thus, the current behavior of stopping the job is valid.

• Related Links:

• Issues

• Email: Expected AzCopy Behavior When Exceeding Quotas

Type of Change

• Bug fix
• New feature
• Documentation update required
• Code quality improvement
• Other (describe):

How Has This Been Tested?

Existing e2e tests and new Scenario_UploadFileQuota test
AzCopy randomly uploads files to the file share until the quota is hit. Wrote a script to validate that these uploaded files are non-empty. If empty files are uploaded, they are correctly deleted in the cleanup handler in the codebase.

Thank you for your contribution to AzCopy!

[adreed-msft]

Test doesn't adequately test the change in question

[adreed-msft]

Looks good-- One concern about test efficiency that I'd like you to take a proper look at, but worst case it can be a remediation item next release.