Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for File Share Limit Reached Error #2895

Merged
merged 16 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/make.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,6 @@ func init() {
},
}

makeCmd.PersistentFlags().Uint32Var(&rawArgs.quota, "quota-gb", 0, "Specifies the maximum size of the share in gigabytes (GiB), 0 means you accept the file service's default quota.")
makeCmd.PersistentFlags().Uint32Var(&rawArgs.quota, "quota-gb", 0, "Specifies the maximum size of the share in gigabytes (GiB), 0 means you accept the file service's default quota. If `ShareSizeLimitReached` error is hit, increase quota and call resume command.")
wonwuakpa-msft marked this conversation as resolved.
Show resolved Hide resolved
rootCmd.AddCommand(makeCmd)
}
5 changes: 3 additions & 2 deletions ste/jobStatusManager.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
package ste

import (
"sync"
"time"

"github.com/Azure/azure-storage-azcopy/v10/common"
Expand All @@ -44,6 +45,7 @@ type jobStatusManager struct {
xferDone chan xferDoneMsg
xferDoneDrained chan struct{} // To signal that all xferDone have been processed
statusMgrDone chan struct{} // To signal statusManager has closed
once sync.Once // Ensure xferDoneDrained is closed once
}

func (jm *jobMgr) waitToDrainXferDone() {
Expand Down Expand Up @@ -134,10 +136,9 @@ func (jm *jobMgr) handleStatusUpdateMessage() {
case msg, ok := <-jstm.xferDone:
if !ok { // Channel is closed, all transfers have been attended.
jstm.xferDone = nil

// close drainXferDone so that other components can know no further updates happen
allXferDoneHandled = true
close(jstm.xferDoneDrained)
jstm.once.Do(func() { close(jstm.xferDoneDrained) })
continue
}

Expand Down
1 change: 1 addition & 0 deletions ste/mgr-JobMgr.go
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ func (jm *jobMgr) reportJobPartDoneHandler() {
// Inform StatusManager that all parts are done.
if jm.jstm.xferDone != nil {
close(jm.jstm.xferDone)
// jm.jstm.xferDone = nil
}

// Wait for all XferDone messages to be processed by statusManager. Front end
Expand Down
Loading