Skip to content

Conversation

@wonwuakpa-msft
Copy link
Member

Description

  • Feature / Bug Fix: (Brief description of the feature or issue being addressed)

  • Related Links:

  • Issues

  • Team thread

  • Documents

  • [Email Subject]

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Thank you for your contribution to AzCopy!

@wonwuakpa-msft wonwuakpa-msft marked this pull request as ready for review November 19, 2025 15:11
Copilot AI review requested due to automatic review settings November 19, 2025 15:11
Copilot finished reviewing on behalf of wonwuakpa-msft November 19, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to prevent GitHub release overwrites by changing the GitHub release task action from 'edit' to 'create' in the CI/CD pipeline.

Key Changes:

  • Modified the GithubRelease@1 task action parameter from 'edit' to 'create'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

githubConnection: 'azcopy-github-connection'
repositoryName: 'Azure/azure-storage-azcopy'
action: 'edit'
action: 'create'
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the action from 'edit' to 'create' may cause pipeline failures when a GitHub release with the same tag already exists. The 'create' action will fail if the release tag is already present, whereas 'edit' would update the existing release.

If the intent is to prevent overwriting releases, consider:

  1. Using 'create' with additional checks to ensure the tag doesn't exist
  2. Using 'edit' with addChangeLog: false or similar parameters to prevent unintended overwrites
  3. Adding conditional logic to check if the release exists before deciding whether to create or edit

Note that assetUploadMode: replace on line 1056 already controls asset overwriting behavior, so this change may not achieve the intended goal of preventing overwrites.

Suggested change
action: 'create'
action: 'edit'

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant