Skip to content

removed release overwrites #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wonwuakpa-msft wants to merge 2 commits into
base: main
Choose a base branch
from
Open

removed release overwrites #3297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
034a907
removed release overwrites
wonwuakpa-msft Nov 19, 2025
add4b7d
Merge branch 'main' into pipeLine
wonwuakpa-msft Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-1es-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@ extends:
inputs:
githubConnection: 'azcopy-github-connection'
repositoryName: 'Azure/azure-storage-azcopy'
action: 'edit'
action: 'create'
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the action from 'edit' to 'create' may cause pipeline failures when a GitHub release with the same tag already exists. The 'create' action will fail if the release tag is already present, whereas 'edit' would update the existing release.

If the intent is to prevent overwriting releases, consider:

  1. Using 'create' with additional checks to ensure the tag doesn't exist
  2. Using 'edit' with addChangeLog: false or similar parameters to prevent unintended overwrites
  3. Adding conditional logic to check if the release exists before deciding whether to create or edit

Note that assetUploadMode: replace on line 1056 already controls asset overwriting behavior, so this change may not achieve the intended goal of preventing overwrites.

Suggested change
action: 'create'
action: 'edit'

Copilot uses AI. Check for mistakes.
target: '$(Build.SourceVersion)'
tagSource: 'userSpecifiedTag'
title: "AzCopy v$(azcopy_version)"
Expand Down
Loading