Bump all GitHub action dependencies for Node20 breaking change alert #5396
+68
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBurnside
added
the
does not need changelog
@azure/communication-react jest test coverage for stable.
|
JamesBurnside
temporarily deployed
to
production
GitHub Actions
Inactive
@azure/communication-react jest test coverage for beta.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bhohonmomz.chromatic.com/ |
JamesBurnside
requested review from
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms and
waynemo
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
Chat bundle size is decreased✅.
|
JoshuaLai
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bump all
usesin github actions to their respective latest versionsWhy
https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/
we want to ensure we have no deprecation warnings across any action, e.g.:
How Tested
npm-release-publish.yml: not performed - review closelyci.yml: https://github.com/Azure/communication-ui-library/actions/runs/11710055156?pr=5396codeql-analysis.yml: https://github.com/Azure/communication-ui-library/actions/runs/11709870864/job/32614843500?pr=5396create-api-view-feature-level.yml: https://github.com/Azure/communication-ui-library/actions/runs/11710270170deploy-azure-webapps.yml: https://github.com/Azure/communication-ui-library/actions/runs/11710081527deploy-feature-azure-webapps.yml: (covered by above test)deploy-release-azure-webapps.yml: (covered by above test)publish-chromatic.yml: https://github.com/Azure/communication-ui-library/actions/runs/11710239176/job/32616074840?pr=5396stress-test-ui-tests.yml: https://github.com/Azure/communication-ui-library/actions/runs/11710117166update-chat-snapshots.yml: not performed (only artifacts action bumped, which is tested in other tests)update-snapshots.yml: not performed (only artifacts action bumped, which is tested in other tests)