Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all GitHub action dependencies for Node20 breaking change alert #5396

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
run: rush ensure-consistent-versions
# Upload azure-communication api.md files for easy access
- name: Upload communication-react api files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: communication-react.${{ matrix.flavor }}.api.json
path: |
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:
run: npx nyc report --temp-dir temp/jest/current/merge/detailed-full/ --report-dir temp/jest/current/merge/summary/ --reporter json-summary
# Upload coverage report to review the merged report locally
- name: Upload detailed and summary jest coverage reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: jest-coverage-report-${{ matrix.flavor }}
path: temp/jest/current/merge/
Expand All @@ -182,15 +182,15 @@ jobs:
node ./common/config/workflows/coverage-utils.js ../../../temp/jest/base/coverage-report.json ../../../temp/jest/current/merge/summary/coverage-summary.json branches
- name: Find Comment
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.base.ref, 'release/') }}
uses: peter-evans/find-comment@v2
uses: peter-evans/find-comment@v3
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: '## @azure/communication-react jest test coverage for ***${{ matrix.flavor }}'
- name: Create or update comment
if: ${{ github.event_name == 'pull_request' && !startsWith(github.event.pull_request.base.ref, 'release/') }}
uses: peter-evans/create-or-update-comment@v2
uses: peter-evans/create-or-update-comment@v4
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
# Upload azure-communication api.md files for easy access
- name: Upload communication-react api files
if: ${{ matrix.flavor == 'beta-release'}}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: communication-react.beta-release.api.json
path: |
Expand Down Expand Up @@ -308,25 +308,25 @@ jobs:
CONNECTION_STRING: ${{ secrets.CONNECTION_STRING }}
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload playwright test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: e2e-results-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.flavor }}-call.json
path: packages/react-composites/test-results/*/e2e-results.json
if-no-files-found: error
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: snapshots
path: packages/react-composites/test-results
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -375,25 +375,25 @@ jobs:
CONNECTION_STRING: ${{ secrets.CONNECTION_STRING }}
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload playwright test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: e2e-results-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.flavor }}-chat.json
path: packages/react-composites/test-results/*/e2e-results.json
if-no-files-found: error
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: snapshots
path: packages/react-composites/test-results
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -442,25 +442,25 @@ jobs:
CONNECTION_STRING: ${{ secrets.CONNECTION_STRING }}
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload playwright test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: e2e-results-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.flavor }}-callwithchat.json
path: packages/react-composites/test-results/*/e2e-results.json
if-no-files-found: error
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: snapshots
path: packages/react-composites/test-results
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -505,17 +505,17 @@ jobs:
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Components-snapshots
path: packages/react-components/tests/temp
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -579,7 +579,7 @@ jobs:
- name: Tests
run: rush test -o calling
# upload bundle stats.json which will be consumed later
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ matrix.flavor == 'beta'}}
with:
name: Calling-report
Expand Down Expand Up @@ -611,7 +611,7 @@ jobs:
- name: Tests
run: rush test -o chat
# upload bundle stats.json which will be consumed later
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ matrix.flavor == 'beta'}}
with:
name: Chat-report
Expand Down Expand Up @@ -643,7 +643,7 @@ jobs:
- name: Tests
run: rush test -o callwithchat
# upload bundle stats.json which will be consumed later
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ matrix.flavor == 'beta'}}
with:
name: CallWithChat-report
Expand Down Expand Up @@ -708,17 +708,17 @@ jobs:
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: snapshots
path: samples/tests/test-results/ # or path/to/artifact
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -758,17 +758,17 @@ jobs:
CHROME_PATH: ${{ steps.setup-chrome.outputs.chrome-path }}
- name: Upload snapshot diff
if: ${{ always() && steps.visualregressiontests.outcome == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: snapshots
path: samples/tests/test-results/ # or path/to/artifact
- name: Comment on PR
if: ${{ github.event_name == 'pull_request' && always() && steps.visualregressiontests.outcome == 'failure' && !contains( github.event.pull_request.labels.*.name, 'update_snapshots') }}
uses: actions/github-script@v3
uses: actions/github-script@v7
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -796,7 +796,7 @@ jobs:
# checkout base bundle stats
- name: Get bundle stats of main from gist
run: curl -o base/report.json "${{ matrix.gist }}/raw/${{ matrix.app }}-report.json" --create-dirs -L
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
path: current
name: ${{ matrix.app }}-report
Expand All @@ -811,7 +811,7 @@ jobs:
echo "change=${change}" >> $GITHUB_OUTPUT
echo "diff=$(($current_size - $base_size))" >> $GITHUB_OUTPUT
- name: Find Comment
uses: peter-evans/find-comment@v2
uses: peter-evans/find-comment@v3
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -820,24 +820,24 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Delete existing comment
uses: actions/github-script@v4
uses: actions/github-script@v7
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const commentId = '${{ steps.fc.outputs.comment-id }}'
if (commentId) {
await github.issues.deleteComment({
await github.rest.issues.deleteComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: commentId
})
}
- name: Post new comment
uses: actions/github-script@v4
uses: actions/github-script@v7
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
await github.issues.createComment({
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
Expand Down Expand Up @@ -873,7 +873,7 @@ jobs:
- app: CallWithChat
gist_id: 72a7fca0af8a3c5b37f966bb6d4bcd11
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ${{ matrix.app }}-report
- name: Upload bundle report to gist
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -59,7 +59,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -73,4 +73,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v3
2 changes: 1 addition & 1 deletion .github/workflows/create-api-view-feature-level.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: rush generate-api-diff --feature ${{ github.event.inputs.feature }}
# Upload apis as artifact
- name: Upload apis as action artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: apis
path: apis/
8 changes: 4 additions & 4 deletions .github/workflows/deploy-azure-webapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
run: rush build

- name: Log in with Azure
uses: azure/login@v1
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
Expand All @@ -69,7 +69,7 @@ jobs:
working-directory: ./samples/Calling

- name: 'Deploy Calling Sample WebApp'
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-calling-hero
package: ./samples/Calling/dist
Expand All @@ -79,7 +79,7 @@ jobs:
working-directory: ./samples/Chat

- name: 'Deploy Chat Sample WebApp'
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-chat-hero
package: ./samples/Chat/dist
Expand All @@ -89,7 +89,7 @@ jobs:
working-directory: ./samples/CallWithChat

- name: 'Deploy CallWithChat Sample WebApp'
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-meeting-hero
package: ./samples/CallWithChat/dist
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/deploy-feature-azure-webapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ jobs:
run: rushx package
working-directory: ./samples/Calling
- name: Log in with Azure
uses: azure/login@v1
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: Deploy Calling
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-call-feature-validation
package: ./samples/Calling/dist
Expand Down Expand Up @@ -85,13 +85,13 @@ jobs:
run: rushx package
working-directory: ./samples/Chat
- name: Log in with Azure
uses: azure/login@v1
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: Deploy Chat
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-chat-feature-validation
package: ./samples/Chat/dist
Expand Down Expand Up @@ -127,13 +127,13 @@ jobs:
run: rushx package
working-directory: ./samples/CallWithChat
- name: Log in with Azure
uses: azure/login@v1
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: Deploy CallWithChat
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: acs-ui-dev-web-callwithchat-feature-validation
package: ./samples/CallWithChat/dist
Loading
Loading